chrome/android/java/res/layout/translate_menu_item.xml - Issue 2806273002: Make the Translate Overflow Menu using ListPopupWindow

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/translate_menu_item.xml

Issue 2806273002: Make the Translate Overflow Menu using ListPopupWindow (Closed)

Patch Set: Fix according to comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"

	7 style="@style/AppMenuItem"

	8 android:layout_width="match_parent"

	9 android:layout_height="48dp" >
	Marti Wong 2017/04/12 02:13:42 height is 48dp according to the static specs. height is 48dp according to the static specs. gone 2017/04/12 17:17:33 @dimen/min_touch_target_size? Show quoted text On 2017/04/12 02:13:42, Marti Wong wrote: > height is 48dp according to the static specs. @dimen/min_touch_target_size? Marti Wong 2017/04/13 02:02:12 Thanks for point this out. It seems attr/listPrefe Show quoted text On 2017/04/12 17:17:33, overloaded (dfalcantara) wrote: > On 2017/04/12 02:13:42, Marti Wong wrote: > > height is 48dp according to the static specs. > > @dimen/min_touch_target_size? Thanks for point this out. It seems attr/listPreferredItemHeightSmall (which is also 48dp) is more meaningful here. It is also used in AppMenu and bookmark_popup_item.
	10

	11 <TextView

	12 android:id="@+id/menu_item_text"

	13 android:textAppearance="?android:attr/textAppearanceLargePopupMenu"

	14 android:layout_width="match_parent"

	15 android:layout_height="match_parent"

	16 android:layout_gravity="start"

	17 android:gravity="center_vertical"

	18 android:singleLine="true" />

	19

	20 </FrameLayout>

OLD	NEW