chrome/android/java/res/layout/translate_menu_spinner_divider.xml - Issue 2806273002: Make the Translate Overflow Menu using ListPopupWindow

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/translate_menu_spinner_divider.xml

Issue 2806273002: Make the Translate Overflow Menu using ListPopupWindow (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <!-- Wrap a framelayout because android list view does not respect margins. -->

	7 <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"

	8 android:layout_width="match_parent"

	9 android:layout_height="17dp" >

	10

	11 <View

	12 android:layout_width="match_parent"

	13 android:layout_height="1dp"

	14 android:layout_gravity="center_vertical"

	15 android:background="#ffD6D6D6" />
	gone 2017/04/10 20:00:16 1) Where's this color defined in the mock? 2) New 1) Where's this color defined in the mock? 2) New colors should go into colors.xml. 3) Don't mix lowercase and uppercase. 4) You don't actually need the first ff. Marti Wong 2017/04/11 14:46:18 Color added to colors.xml. thanks (according to t Show quoted text On 2017/04/10 20:00:16, overloaded wrote: > 1) Where's this color defined in the mock? > 2) New colors should go into colors.xml. > 3) Don't mix lowercase and uppercase. > 4) You don't actually need the first ff. Color added to colors.xml. thanks (according to the static mock from Bruno, the divider color is e0e0e0)
	16 </FrameLayout>

OLD	NEW