Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: content/browser/site_per_process_browsertest.cc

Issue 2806263005: Convert the overlay scrollbar flag to use FeatureList (Closed)
Patch Set: dcheng comment addressed Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/site_per_process_browsertest.h" 5 #include "content/browser/site_per_process_browsertest.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
11 #include <map> 11 #include <map>
12 #include <set> 12 #include <set>
13 #include <vector> 13 #include <vector>
14 14
15 #include "base/bind.h" 15 #include "base/bind.h"
16 #include "base/callback.h" 16 #include "base/callback.h"
17 #include "base/command_line.h" 17 #include "base/command_line.h"
18 #include "base/feature_list.h"
18 #include "base/location.h" 19 #include "base/location.h"
19 #include "base/memory/ptr_util.h" 20 #include "base/memory/ptr_util.h"
20 #include "base/path_service.h" 21 #include "base/path_service.h"
21 #include "base/sequenced_task_runner.h" 22 #include "base/sequenced_task_runner.h"
22 #include "base/single_thread_task_runner.h" 23 #include "base/single_thread_task_runner.h"
23 #include "base/strings/pattern.h" 24 #include "base/strings/pattern.h"
24 #include "base/strings/stringprintf.h" 25 #include "base/strings/stringprintf.h"
25 #include "base/strings/utf_string_conversions.h" 26 #include "base/strings/utf_string_conversions.h"
26 #include "base/test/test_timeouts.h" 27 #include "base/test/test_timeouts.h"
27 #include "base/threading/sequenced_task_runner_handle.h" 28 #include "base/threading/sequenced_task_runner_handle.h"
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 #include "third_party/WebKit/public/platform/WebInputEvent.h" 81 #include "third_party/WebKit/public/platform/WebInputEvent.h"
81 #include "third_party/WebKit/public/platform/WebInsecureRequestPolicy.h" 82 #include "third_party/WebKit/public/platform/WebInsecureRequestPolicy.h"
82 #include "third_party/WebKit/public/web/WebSandboxFlags.h" 83 #include "third_party/WebKit/public/web/WebSandboxFlags.h"
83 #include "ui/display/display_switches.h" 84 #include "ui/display/display_switches.h"
84 #include "ui/display/screen.h" 85 #include "ui/display/screen.h"
85 #include "ui/events/base_event_utils.h" 86 #include "ui/events/base_event_utils.h"
86 #include "ui/events/event.h" 87 #include "ui/events/event.h"
87 #include "ui/events/event_utils.h" 88 #include "ui/events/event_utils.h"
88 #include "ui/gfx/geometry/point.h" 89 #include "ui/gfx/geometry/point.h"
89 #include "ui/latency/latency_info.h" 90 #include "ui/latency/latency_info.h"
90 #include "ui/native_theme/native_theme_switches.h" 91 #include "ui/native_theme/native_theme_features.h"
91 92
92 #if defined(USE_AURA) 93 #if defined(USE_AURA)
93 #include "content/browser/renderer_host/render_widget_host_view_aura.h" 94 #include "content/browser/renderer_host/render_widget_host_view_aura.h"
94 #endif 95 #endif
95 96
96 #if defined(OS_MACOSX) 97 #if defined(OS_MACOSX)
97 #include "ui/base/test/scoped_preferred_scroller_style_mac.h" 98 #include "ui/base/test/scoped_preferred_scroller_style_mac.h"
98 #endif 99 #endif
99 100
100 #if defined(OS_ANDROID) 101 #if defined(OS_ANDROID)
(...skipping 511 matching lines...) Expand 10 before | Expand all | Expand 10 after
612 SitePerProcessBrowserTest::SitePerProcessBrowserTest() { 613 SitePerProcessBrowserTest::SitePerProcessBrowserTest() {
613 }; 614 };
614 615
615 std::string SitePerProcessBrowserTest::DepictFrameTree(FrameTreeNode* node) { 616 std::string SitePerProcessBrowserTest::DepictFrameTree(FrameTreeNode* node) {
616 return visualizer_.DepictFrameTree(node); 617 return visualizer_.DepictFrameTree(node);
617 } 618 }
618 619
619 void SitePerProcessBrowserTest::SetUpCommandLine( 620 void SitePerProcessBrowserTest::SetUpCommandLine(
620 base::CommandLine* command_line) { 621 base::CommandLine* command_line) {
621 IsolateAllSitesForTesting(command_line); 622 IsolateAllSitesForTesting(command_line);
623 }
624
625 void SitePerProcessBrowserTest::SetUpOnMainThread() {
622 #if !defined(OS_ANDROID) 626 #if !defined(OS_ANDROID)
623 // TODO(bokan): Needed for scrollability check in 627 // TODO(bokan): Needed for scrollability check in
624 // FrameOwnerPropertiesPropagationScrolling. crbug.com/662196. 628 // FrameOwnerPropertiesPropagationScrolling. crbug.com/662196.
625 command_line->AppendSwitch(switches::kDisableOverlayScrollbar); 629 base::FeatureList* existing_feature_list = base::FeatureList::GetInstance();
630
631 std::vector<std::string> disables{
632 std::string(features::kOverlayScrollbar.name)};
633 feature_list_.InitWithFeatureListAndOverrides(
634 existing_feature_list, std::vector<std::string>(), disables);
626 #endif 635 #endif
627 };
628 636
629 void SitePerProcessBrowserTest::SetUpOnMainThread() {
630 host_resolver()->AddRule("*", "127.0.0.1"); 637 host_resolver()->AddRule("*", "127.0.0.1");
631 SetupCrossSiteRedirector(embedded_test_server()); 638 SetupCrossSiteRedirector(embedded_test_server());
632 ASSERT_TRUE(embedded_test_server()->Start()); 639 ASSERT_TRUE(embedded_test_server()->Start());
633 } 640 }
634 641
635 // 642 //
636 // SitePerProcessHighDPIBrowserTest 643 // SitePerProcessHighDPIBrowserTest
637 // 644 //
638 645
639 646
(...skipping 9221 matching lines...) Expand 10 before | Expand all | Expand 10 after
9861 names.insert(root->children[0]->frame_entry->frame_unique_name()); 9868 names.insert(root->children[0]->frame_entry->frame_unique_name());
9862 } 9869 }
9863 9870
9864 // More than one entry in the set means that the subframe frame navigation 9871 // More than one entry in the set means that the subframe frame navigation
9865 // entries didn't have a consistent unique name. This will break history 9872 // entries didn't have a consistent unique name. This will break history
9866 // navigations =( 9873 // navigations =(
9867 EXPECT_THAT(names, SizeIs(1)) << "Mismatched names for subframe!"; 9874 EXPECT_THAT(names, SizeIs(1)) << "Mismatched names for subframe!";
9868 } 9875 }
9869 9876
9870 } // namespace content 9877 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698