Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2806263005: Convert the overlay scrollbar flag to use FeatureList (Closed)
Patch Set: add test for scoped_feature_list Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 #include "printing/features/features.h" 90 #include "printing/features/features.h"
91 #include "services/device/public/cpp/device_features.h" 91 #include "services/device/public/cpp/device_features.h"
92 #include "ui/base/ui_base_switches.h" 92 #include "ui/base/ui_base_switches.h"
93 #include "ui/compositor/compositor_switches.h" 93 #include "ui/compositor/compositor_switches.h"
94 #include "ui/display/display_switches.h" 94 #include "ui/display/display_switches.h"
95 #include "ui/events/event_switches.h" 95 #include "ui/events/event_switches.h"
96 #include "ui/gfx/switches.h" 96 #include "ui/gfx/switches.h"
97 #include "ui/gl/gl_features.h" 97 #include "ui/gl/gl_features.h"
98 #include "ui/gl/gl_switches.h" 98 #include "ui/gl/gl_switches.h"
99 #include "ui/keyboard/keyboard_switches.h" 99 #include "ui/keyboard/keyboard_switches.h"
100 #include "ui/native_theme/native_theme_switches.h" 100 #include "ui/native_theme/native_theme_features.h"
101 #include "ui/views/views_switches.h" 101 #include "ui/views/views_switches.h"
102 102
103 #if defined(OS_ANDROID) 103 #if defined(OS_ANDROID)
104 #include "chrome/browser/android/chrome_feature_list.h" 104 #include "chrome/browser/android/chrome_feature_list.h"
105 #include "components/feature_engagement_tracker/public/feature_constants.h" 105 #include "components/feature_engagement_tracker/public/feature_constants.h"
106 #else // OS_ANDROID 106 #else // OS_ANDROID
107 #include "ui/message_center/message_center_switches.h" 107 #include "ui/message_center/message_center_switches.h"
108 #endif // OS_ANDROID 108 #endif // OS_ANDROID
109 109
110 #if defined(OS_CHROMEOS) 110 #if defined(OS_CHROMEOS)
(...skipping 900 matching lines...) Expand 10 before | Expand all | Expand 10 after
1011 flag_descriptions::kSmoothScrollingDescription, 1011 flag_descriptions::kSmoothScrollingDescription,
1012 // Mac has a separate implementation with its own setting to disable. 1012 // Mac has a separate implementation with its own setting to disable.
1013 kOsLinux | kOsCrOS | kOsWin | kOsAndroid, 1013 kOsLinux | kOsCrOS | kOsWin | kOsAndroid,
1014 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableSmoothScrolling, 1014 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableSmoothScrolling,
1015 switches::kDisableSmoothScrolling)}, 1015 switches::kDisableSmoothScrolling)},
1016 #if defined(USE_AURA) 1016 #if defined(USE_AURA)
1017 {"overlay-scrollbars", flag_descriptions::kOverlayScrollbarsName, 1017 {"overlay-scrollbars", flag_descriptions::kOverlayScrollbarsName,
1018 flag_descriptions::kOverlayScrollbarsDescription, 1018 flag_descriptions::kOverlayScrollbarsDescription,
1019 // Uses the system preference on Mac (a different implementation). 1019 // Uses the system preference on Mac (a different implementation).
1020 // On Android, this is always enabled. 1020 // On Android, this is always enabled.
1021 kOsAura, 1021 kOsAura, FEATURE_VALUE_TYPE(features::kOverlayScrollbar)},
1022 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableOverlayScrollbar,
1023 switches::kDisableOverlayScrollbar)},
1024 #endif // USE_AURA 1022 #endif // USE_AURA
1025 { // See http://crbug.com/120416 for how to remove this flag. 1023 { // See http://crbug.com/120416 for how to remove this flag.
1026 "save-page-as-mhtml", flag_descriptions::kSavePageAsMhtmlName, 1024 "save-page-as-mhtml", flag_descriptions::kSavePageAsMhtmlName,
1027 flag_descriptions::kSavePageAsMhtmlDescription, kOsMac | kOsWin | kOsLinux, 1025 flag_descriptions::kSavePageAsMhtmlDescription, kOsMac | kOsWin | kOsLinux,
1028 SINGLE_VALUE_TYPE(switches::kSavePageAsMHTML)}, 1026 SINGLE_VALUE_TYPE(switches::kSavePageAsMHTML)},
1029 {"mhtml-generator-option", flag_descriptions::kMhtmlGeneratorOptionName, 1027 {"mhtml-generator-option", flag_descriptions::kMhtmlGeneratorOptionName,
1030 flag_descriptions::kMhtmlGeneratorOptionDescription, 1028 flag_descriptions::kMhtmlGeneratorOptionDescription,
1031 kOsMac | kOsWin | kOsLinux, 1029 kOsMac | kOsWin | kOsLinux,
1032 MULTI_VALUE_TYPE(kMHTMLGeneratorOptionChoices)}, 1030 MULTI_VALUE_TYPE(kMHTMLGeneratorOptionChoices)},
1033 {"enable-quic", flag_descriptions::kQuicName, 1031 {"enable-quic", flag_descriptions::kQuicName,
(...skipping 1840 matching lines...) Expand 10 before | Expand all | Expand 10 after
2874 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2872 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2875 2873
2876 const FeatureEntry* GetFeatureEntries(size_t* count) { 2874 const FeatureEntry* GetFeatureEntries(size_t* count) {
2877 *count = arraysize(kFeatureEntries); 2875 *count = arraysize(kFeatureEntries);
2878 return kFeatureEntries; 2876 return kFeatureEntries;
2879 } 2877 }
2880 2878
2881 } // namespace testing 2879 } // namespace testing
2882 2880
2883 } // namespace about_flags 2881 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698