Convert main NTP panel to UIViewController.

ios/chrome/browser/ui/ntp/new_tab_page_controller.mm

Index: ios/chrome/browser/ui/ntp/new_tab_page_controller.mm
diff --git a/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm b/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm
index ec65f615c8b837fb8ab11f21d5b4546ceeee4546..ba83851f11283d8adee46dedbb49911e14b23470 100644
--- a/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm
+++ b/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm
@@ -164,6 +164,7 @@ enum {
 
 @synthesize ntpView = newTabPageView_;
 @synthesize swipeRecognizerProvider = swipeRecognizerProvider_;
+@synthesize parentViewController = parentViewController_;
 
 - (id)initWithUrl:(const GURL&)url
                 loader:(id<UrlLoader>)loader
@@ -278,6 +279,11 @@ enum {
   // Animations can last past the life of the NTP controller, nil out the
   // delegate.
   self.ntpView.scrollView.delegate = nil;
+
+  // TODO(crbug.com/708319): Also call -removeFromParentViewController for
+  // bookmarks, open tabs and incognit here.
+  [googleLandingController_ removeFromParentViewController];
+
   [googleLandingController_ setDelegate:nil];
   [bookmarkController_ setDelegate:nil];
   [openTabsController_ setDelegate:nil];
@@ -287,9 +293,11 @@ enum {
 
 #pragma mark - CRWNativeContent
 
-// Note: No point implementing -handleLowMemory because all native content
-// views but the selected one are dropped, and the selected view doesn't
-// need to do anything.
+- (void)willBeDismissed {

[rohitrao (ping after 24h), 2017/04/13 12:48:52]

Explain that this is called by //web immediately before this controller's view
is removed from the view hierarchy.

[justincohen, 2017/04/13 13:58:02]

Done.

+  // TODO(crbug.com/708319): Also call -willMoveToParentViewController:nil for
+  // bookmarks, open tabs and incognito here.
+  [googleLandingController_ willMoveToParentViewController:nil];
+}
 
 - (void)reload {
   [currentController_ reload];
@@ -485,7 +493,8 @@ enum {
 }
 
 - (BOOL)loadPanel:(NewTabPageBarItem*)item {
-  UIView* view;
+  UIView* view = nil;
+  UIViewController* panelController = nil;
   BOOL created = NO;
   // Only load the controllers once.
   if (item.identifier == NewTabPage::kBookmarksPanel) {
@@ -498,6 +507,7 @@ enum {
                                       colorCache:dominantColorCache_] retain]);
     }
     view = [bookmarkController_ view];
+    // TODO(crbug.com/708319): Also set panelController for bookmarks here.
     [bookmarkController_ setDelegate:self];
   } else if (item.identifier == NewTabPage::kMostVisitedPanel) {
     if (!googleLandingController_) {
@@ -508,6 +518,7 @@ enum {
           webToolbarDelegate:webToolbarDelegate_
                     tabModel:tabModel_]);
     }
+    panelController = googleLandingController_;
     view = [googleLandingController_ view];
     [googleLandingController_ setDelegate:self];
   } else if (item.identifier == NewTabPage::kOpenTabsPanel) {
@@ -515,6 +526,7 @@ enum {
       openTabsController_.reset([[RecentTabsPanelController alloc]
           initWithLoader:loader_
             browserState:browserState_]);
+    // TODO(crbug.com/708319): Also set panelController for opentabs here.
     view = [openTabsController_ view];
     [openTabsController_ setDelegate:self];
   } else if (item.identifier == NewTabPage::kIncognitoPanel) {
@@ -523,6 +535,7 @@ enum {
               initWithLoader:loader_
                 browserState:browserState_
           webToolbarDelegate:webToolbarDelegate_]);
+    // TODO(crbug.com/708319): Also set panelController for incognito here.
     view = [incognitoController_ view];
   } else {
     NOTREACHED();
@@ -535,7 +548,21 @@ enum {
     created = YES;
     view.frame = [self.ntpView panelFrameForItemAtIndex:index];
     item.view = view;
+
+    // To ease modernizing the NTP only the internal panels are being converted
+    // to UIViewControllers.  This means all the plumbing between the
+    // BrowserViewController and the internal NTP panels (WebController, NTP)
+    // hierarchy is skipped.  While normally the logic to push and pop a view
+    // controller would be owned by a coordinator, in this case the old NTP
+    // controller adds and removes child view controllers itself when a load
+    // is initiated, and when WebController calls -willBeDismissed.
+    // TODO(crbug.com/708319):This 'if' can become a DCHECK once all panels move
+    // to panelControllers.
+    if (panelController)
+      [self.parentViewController addChildViewController:panelController];
     [self.ntpView.scrollView addSubview:view];
+    if (panelController)
+      [panelController didMoveToParentViewController:self.parentViewController];
   }
   return created;
 }