ios/chrome/browser/ui/browser_view_controller.mm - Issue 2806153004: Convert main NTP panel to UIViewController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2806153004: Convert main NTP panel to UIViewController. (Closed)

Patch Set: Address comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/browser_view_controller.mm

diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm

index a95912d0e10b2bc9c9cfaddf2a6891fd4e96c3cc..37e94578e8ea2f604e6f8992d39b5f549f51bacb 100644

--- a/ios/chrome/browser/ui/browser_view_controller.mm

+++ b/ios/chrome/browser/ui/browser_view_controller.mm

@@ -3036,6 +3036,7 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {

webToolbarDelegate:self

tabModel:_model];

pageController.swipeRecognizerProvider = self.sideSwipeController;

+ pageController.parentViewController = self;

// Panel is always NTP for iPhone.

NewTabPage::PanelIdentifier panelType = NewTabPage::kMostVisitedPanel;