Chromium Code Reviews| Index: ios/chrome/browser/ui/ntp/new_tab_page_controller.h |
| diff --git a/ios/chrome/browser/ui/ntp/new_tab_page_controller.h b/ios/chrome/browser/ui/ntp/new_tab_page_controller.h |
| index fc021d85dab2e044afb7c6ef9be67d3b4f1021bf..e1d128772be9e852b3fe742a4882668b4225eac2 100644 |
| --- a/ios/chrome/browser/ui/ntp/new_tab_page_controller.h |
| +++ b/ios/chrome/browser/ui/ntp/new_tab_page_controller.h |
| @@ -85,6 +85,14 @@ std::string FragmentFromIdentifier(PanelIdentifier panel); |
| @property(nonatomic, assign) id<CRWSwipeRecognizerProvider> |
| swipeRecognizerProvider; |
| +// To ease modernizing the NTP only the internal panels are being converted |
| +// to UIViewControllers. This means all the plumbing between the |
| +// BrowserViewController and the internal NTP panels (WebController, NTP) |
| +// hierarchy is skipped. While normally the logic to push and pop a view |
| +// controller would be owned by a coordinator, in this case the old NTP |
| +// controller adds and removes child view controllers itself when a load |
| +// is initiated, and when WebController calls -willBeDismissed. |
| +@property(nonatomic, assign) UIViewController* parentViewController; |
|
rohitrao (ping after 24h)
2017/04/12 12:45:09
Blank line after.
justincohen
2017/04/12 14:23:12
Done.
|
| // Init with the given url (presumably "chrome://newtab") and loader object. |
| // |loader| may be nil, but isn't retained so it must outlive this controller. |
| // Dominant color cache is passed to bookmark controller only, to optimize |