Convert main NTP panel to UIViewController.

ios/chrome/browser/ui/ntp/new_tab_page_controller.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/ntp/new_tab_page_controller.h"
 
 #import <QuartzCore/QuartzCore.h>
 
 #import "base/ios/weak_nsobject.h"
 #include "base/logging.h"
@@ skipping 146 matching lines @@
 // Returns the ID for the currently selected panel.
 - (NewTabPage::PanelIdentifier)selectedPanelID;
 
 @property(nonatomic, retain) NewTabPageView* ntpView;
 @end
 
 @implementation NewTabPageController
 
 @synthesize ntpView = newTabPageView_;
 @synthesize swipeRecognizerProvider = swipeRecognizerProvider_;
+@synthesize parentViewController = parentViewController_;
 
 - (id)initWithUrl:(const GURL&)url
                 loader:(id<UrlLoader>)loader
                focuser:(id<OmniboxFocuser>)focuser
            ntpObserver:(id<NewTabPageControllerObserver>)ntpObserver
           browserState:(ios::ChromeBrowserState*)browserState
             colorCache:(NSMutableDictionary*)colorCache
     webToolbarDelegate:(id<WebToolbarDelegate>)webToolbarDelegate
               tabModel:(TabModel*)tabModel {
   self = [super initWithNibName:nil url:url];
@@ skipping 94 matching lines @@
     [self showPanel:itemToDisplay];
     [self updateOverlayScrollPosition];
   }
   return self;
 }
 
 - (void)dealloc {
   // Animations can last past the life of the NTP controller, nil out the
   // delegate.
   self.ntpView.scrollView.delegate = nil;
+
+  // TODO(crbug.com/708319): Also call -removeFromParentViewController for
+  // bookmarks, open tabs and incognit here.
+  [googleLandingController_ removeFromParentViewController];

[rohitrao (ping after 24h), 2017/04/12 12:45:09]

Why is this not covered by the willBeDismissed code below?

[justincohen, 2017/04/12 14:23:12]

-willMoveToParentViewController is called before the view is removed.

-removeFromParentViewController is called after the view is removed.

+
   [googleLandingController_ setDelegate:nil];
   [bookmarkController_ setDelegate:nil];
   [openTabsController_ setDelegate:nil];
   [[NSNotificationCenter defaultCenter] removeObserver:self];
   [super dealloc];
 }
 
 #pragma mark - CRWNativeContent
 
-// Note: No point implementing -handleLowMemory because all native content
-// views but the selected one are dropped, and the selected view doesn't
-// need to do anything.
+- (void)willBeDismissed {
+  // TODO(crbug.com/708319): Also call -willMoveToParentViewController:nil for
+  // bookmarks, open tabs and incognito here.
+  [googleLandingController_ willMoveToParentViewController:nil];
+}
 
 - (void)reload {
   [currentController_ reload];
   [super reload];
 }
 
 - (void)wasShown {
   [currentController_ wasShown];
   // Ensure that the NTP has the latest data when it is shown.
   [self reload];
@@ skipping 175 matching lines @@
 
 - (void)loadControllerWithIndex:(NSUInteger)index {
   if (index >= self.ntpView.tabBar.items.count)
     return;
 
   NewTabPageBarItem* item = [self.ntpView.tabBar.items objectAtIndex:index];
   [self loadPanel:item];
 }
 
 - (BOOL)loadPanel:(NewTabPageBarItem*)item {
   UIView* view;

[rohitrao (ping after 24h), 2017/04/12 12:45:09]

Consider changing this to:

UIView* panelView = nil;
UIViewController* panelViewController = nil;

Then you can set the two variables as needed in the conditional blocks, and if
|panelViewController| is non-nil at line 552, you can add it as a child.

This also gives us a place to leave a gigantic comment about what's happening
and why we're doing it this way.

[justincohen, 2017/04/12 14:23:12]

I was planning on doing this when adding the other view controllers, but I can
do it now too.

   BOOL created = NO;
   // Only load the controllers once.
   if (item.identifier == NewTabPage::kBookmarksPanel) {
     if (!bookmarkController_) {
       base::scoped_nsobject<BookmarkControllerFactory> factory(
           [[BookmarkControllerFactory alloc] init]);
       bookmarkController_.reset([[factory
           bookmarkPanelControllerForBrowserState:browserState_
                                           loader:loader_
                                       colorCache:dominantColorCache_] retain]);
     }
     view = [bookmarkController_ view];
+    // TODO(crbug.com/708319): Also addChildViewController for bookmarks here.
     [bookmarkController_ setDelegate:self];
   } else if (item.identifier == NewTabPage::kMostVisitedPanel) {
     if (!googleLandingController_) {
       googleLandingController_.reset([[GoogleLandingController alloc]
               initWithLoader:loader_
                 browserState:browserState_
                      focuser:focuser_
           webToolbarDelegate:webToolbarDelegate_
                     tabModel:tabModel_]);
     }
+    [self.parentViewController addChildViewController:googleLandingController_];
     view = [googleLandingController_ view];
     [googleLandingController_ setDelegate:self];
   } else if (item.identifier == NewTabPage::kOpenTabsPanel) {
     if (!openTabsController_)
       openTabsController_.reset([[RecentTabsPanelController alloc]
           initWithLoader:loader_
             browserState:browserState_]);
+    // TODO(crbug.com/708319): Also addChildViewController for opentabs here.
     view = [openTabsController_ view];
     [openTabsController_ setDelegate:self];
   } else if (item.identifier == NewTabPage::kIncognitoPanel) {
     if (!incognitoController_)
       incognitoController_.reset([[IncognitoPanelController alloc]
               initWithLoader:loader_
                 browserState:browserState_
           webToolbarDelegate:webToolbarDelegate_]);
+    // TODO(crbug.com/708319): Also addChildViewController for incognito here.
     view = [incognitoController_ view];
   } else {
     NOTREACHED();
     return NO;
   }
 
   // Add the panel views to the scroll view in the proper location.
   NSUInteger index = [self tabBarItemIndex:item];
   if (view.superview == nil) {
     created = YES;
     view.frame = [self.ntpView panelFrameForItemAtIndex:index];
     item.view = view;
     [self.ntpView.scrollView addSubview:view];
+
+    // Also didMoveToParentViewController for bookmarks, open tabs and incognito
+    // here.
+    if (item.identifier == NewTabPage::kMostVisitedPanel) {
+      [googleLandingController_
+          didMoveToParentViewController:self.parentViewController];
+    }
   }
   return created;
 }
 
 - (void)scrollToPanel:(NewTabPageBarItem*)item animate:(BOOL)animate {
   NSUInteger index = [self tabBarItemIndex:item];
   if (IsIPadIdiom()) {
     CGRect itemFrame = [self.ntpView panelFrameForItemAtIndex:index];
     CGPoint point = CGPointMake(CGRectGetMinX(itemFrame), 0);
     [self.ntpView.scrollView setContentOffset:point animated:animate];
@@ skipping 127 matching lines @@
 
 - (void)updateNtpBarShadowForPanelController:
     (id<NewTabPagePanelProtocol>)ntpPanelController {
   if (currentController_ != ntpPanelController)
     return;
   [self.ntpView.tabBar
       setShadowAlpha:[ntpPanelController alphaForBottomShadow]];
 }
 
 @end