Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2806153002: Remove json5_generator.Writer parameters with specification None. (Closed)

Created:
3 years, 8 months ago by shend
Modified:
3 years, 8 months ago
Reviewers:
meade_UTC10, Bugs Nash
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove json5_generator.Writer parameters with specification None. There are a few places where the parameter specification is None. This is intended to indicate that this parameter has no restrictions on its values. However, in actual JSON files, this is expressed by using an empty dictionary '{}' instead of None. This patch changes None to '{}' to be consistent with JSON files. BUG=628043 Review-Url: https://codereview.chromium.org/2806153002 Cr-Commit-Position: refs/heads/master@{#465825} Committed: https://chromium.googlesource.com/chromium/src/+/6a3a1f8d359249a0c9abd5e9630c14a63afebf66

Patch Set 1 #

Patch Set 2 : assert #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M third_party/WebKit/Source/build/scripts/json5_generator.py View 1 1 chunk +3 lines, -2 lines 2 comments Download
M third_party/WebKit/Source/build/scripts/make_event_factory.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/make_names.py View 1 chunk +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (11 generated)
shend
Hi Bugs, PTAL
3 years, 8 months ago (2017-04-10 03:40:57 UTC) #2
Bugs Nash
https://codereview.chromium.org/2806153002/diff/20001/third_party/WebKit/Source/build/scripts/json5_generator.py File third_party/WebKit/Source/build/scripts/json5_generator.py (right): https://codereview.chromium.org/2806153002/diff/20001/third_party/WebKit/Source/build/scripts/json5_generator.py#newcode165 third_party/WebKit/Source/build/scripts/json5_generator.py:165: assert self.parameters[key] is not None, \ This seems to ...
3 years, 8 months ago (2017-04-11 03:16:20 UTC) #3
shend
https://codereview.chromium.org/2806153002/diff/20001/third_party/WebKit/Source/build/scripts/json5_generator.py File third_party/WebKit/Source/build/scripts/json5_generator.py (right): https://codereview.chromium.org/2806153002/diff/20001/third_party/WebKit/Source/build/scripts/json5_generator.py#newcode165 third_party/WebKit/Source/build/scripts/json5_generator.py:165: assert self.parameters[key] is not None, \ On 2017/04/11 at ...
3 years, 8 months ago (2017-04-11 03:19:09 UTC) #4
Bugs Nash
lgtm
3 years, 8 months ago (2017-04-11 04:24:22 UTC) #5
shend
Hi Eddy, PTAL
3 years, 8 months ago (2017-04-12 04:11:44 UTC) #11
meade_UTC10
lgtm
3 years, 8 months ago (2017-04-19 05:18:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806153002/20001
3 years, 8 months ago (2017-04-19 05:30:24 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/425423)
3 years, 8 months ago (2017-04-19 10:53:37 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806153002/20001
3 years, 8 months ago (2017-04-19 22:17:07 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 00:35:04 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6a3a1f8d359249a0c9abd5e9630c...

Powered by Google App Engine
This is Rietveld 408576698