Remove the net_log member from HttpAuthController.

net/http/http_proxy_client_socket.h

Index: net/http/http_proxy_client_socket.h
diff --git a/net/http/http_proxy_client_socket.h b/net/http/http_proxy_client_socket.h
index 4870f0cb927c8f18128f0a47ca6d3f5316e201dc..692cc19e5a98a5bd198c476c440a595cd2ab5026 100644
--- a/net/http/http_proxy_client_socket.h
+++ b/net/http/http_proxy_client_socket.h
@@ -114,25 +114,24 @@ class HttpProxyClientSocket : public ClientSocket {
   // Stores the callback to the layer above, called on completing Connect().
   CompletionCallback* user_callback_;
 
-  // Stores the underlying socket.
-  scoped_ptr<ClientSocketHandle> transport_;
-
-  bool tunnel_;
-
-  std::string request_headers_;
-
-  scoped_ptr<HttpStream> http_stream_;
   HttpRequestInfo request_;

[cbentzel, 2010/07/13 02:13:25]

Is the reordering of member variables intentional? Arguably it may cluster
related variables together which is an improvement.

[vandebo (ex-Chrome), 2010/07/13 16:53:01]

Yes, they were pretty randomly ordered before, and I tried to bring some
semblance of order to them.

   HttpResponseInfo response_;
-  const scoped_refptr<HttpAuthController> auth_;
+
+  scoped_ptr<HttpStream> http_stream_;
+  scoped_refptr<IOBuffer> drain_buf_;
+
+  // Stores the underlying socket.
+  const scoped_ptr<ClientSocketHandle> transport_;
 
   // The hostname and port of the endpoint.  This is not necessarily the one
   // specified by the URL, due to Alternate-Protocol or fixed testing ports.
-  HostPortPair endpoint_;
+  const HostPortPair endpoint_;
+  scoped_refptr<HttpAuthController> auth_;
+  const bool tunnel_;

[cbentzel, 2010/07/13 02:13:25]

I haven't seen const used for POD member variables before. It makes sense here,
but it is a bit different from the rest of the code (which usually is of the
pointed-to-object-is-constant form).

[vandebo (ex-Chrome), 2010/07/13 16:53:01]

I guess const POD isn't used much in the codebase, but I don't see any issues
with this kind of inconsistency. It's easy enough to change if it needs to be
changed, and it provides extra information that makes things easier to
understand.

 
-  scoped_refptr<IOBuffer> drain_buf_;
+  std::string request_headers_;
 
-  BoundNetLog net_log_;
+  const BoundNetLog net_log_;
 
   DISALLOW_COPY_AND_ASSIGN(HttpProxyClientSocket);
 };