Correct description in ADM/ADMX template and change registry key to "Chrome" from "Google Chrome"

Fix multiple issues with ADM/ADMX templates 

Correct descriptions in ADM/ADMX template and change registry key to "Chrome" from "Google Chrome".

Fix numerous punctuation, verbiage and wording issues.

Fix HomepageIsNewTabPage so that not checking the checkbox actually forces the hompage to the homepage URL.

BUG=none
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51251

[danno, 2010-06-29 10:01:15]

please review: frank the ADM/X changes, Bernhard for the committer's LGTM :-)

[Bernhard Bauer, 2010-06-29 10:03:43]

http://codereview.chromium.org/2806040/diff/1/2
File chrome/app/policy/windows/adm/en-US/chrome.adm (right):

http://codereview.chromium.org/2806040/diff/1/2#newcode155
chrome/app/policy/windows/adm/en-US/chrome.adm:155:
DnsPrefetchingEnabled="Enable search suggestions."
"Enable DNS prefetching"?

http://codereview.chromium.org/2806040/diff/1/2#newcode156
chrome/app/policy/windows/adm/en-US/chrome.adm:156:
DnsPrefetchingEnabled_Explain="This policy enables DNS prefething."
Nit: "prefetching".

http://codereview.chromium.org/2806040/diff/1/3
File chrome/app/policy/windows/admx/en-US/chrome.adml (right):

http://codereview.chromium.org/2806040/diff/1/3#newcode40
chrome/app/policy/windows/admx/en-US/chrome.adml:40: <string
id="DnsPrefetchingEnabled">Enable search suggestions.</string>
"Enable DNS prefetching"?

[danno, 2010-06-29 10:09:55]

http://codereview.chromium.org/2806040/diff/1/2
File chrome/app/policy/windows/adm/en-US/chrome.adm (right):

http://codereview.chromium.org/2806040/diff/1/2#newcode155
chrome/app/policy/windows/adm/en-US/chrome.adm:155:
DnsPrefetchingEnabled="Enable search suggestions."
On 2010/06/29 10:03:44, Bernhard Bauer wrote:
> "Enable DNS prefetching"?

Done.

http://codereview.chromium.org/2806040/diff/1/2#newcode156
chrome/app/policy/windows/adm/en-US/chrome.adm:156:
DnsPrefetchingEnabled_Explain="This policy enables DNS prefething."
On 2010/06/29 10:03:44, Bernhard Bauer wrote:
> Nit: "prefetching".

Done.

http://codereview.chromium.org/2806040/diff/1/3
File chrome/app/policy/windows/admx/en-US/chrome.adml (right):

http://codereview.chromium.org/2806040/diff/1/3#newcode40
chrome/app/policy/windows/admx/en-US/chrome.adml:40: <string
id="DnsPrefetchingEnabled">Enable search suggestions.</string>
On 2010/06/29 10:03:44, Bernhard Bauer wrote:
> "Enable DNS prefetching"?

Done.

[Bernhard Bauer, 2010-06-29 10:11:33]

LGTM.

[fmantek_google.com, 2010-06-29 10:23:15]

LGTM as well.

On Tue, Jun 29, 2010 at 12:11 PM, <bauerb@chromium.org> wrote:

> LGTM.
>
>
> http://codereview.chromium.org/2806040/show
>

[danno, 2010-06-29 13:52:12]

sorry fellas, here's another round. After finding a few further minor nits
myself, I realized that the wording, punctuation and verbiage of our template
doesn't match the other templates that Microsoft provides. I tried my hardest to
make the templates conform, too.

[fmantek_google.com, 2010-06-29 14:01:29]

Shouldn't the wording match the other templates Google provides?

(not sure that there is a difference).

Why did you change the Homepage UI to have a dropdown and an edittext vs a
checkbox and an edit text?

Frank

On Tue, Jun 29, 2010 at 3:52 PM, <danno@chromium.org> wrote:

> sorry fellas, here's another round. After finding a few further minor nits
> myself, I realized that the wording, punctuation and verbiage of our
> template
> doesn't match the other templates that Microsoft provides. I tried my
> hardest to
> make the templates conform, too.
>
>
> http://codereview.chromium.org/2806040/show
>

[danno, 2010-06-30 07:44:43]

Actually, I think it's better that our templates are follow the "typical
windows" style. If the Omaha templates don't, then maybe we might want to
address that separately.

 Here are examples of the  things I changed. I observed them in the majority of
the random sampling of built-in windows policies that I looked at:

- No punctuation for checkbox policy elements, unless in the descriptive text
before. Colon after label on elements for everything else (e.g. drop-downs, edit
text fields)
- Descriptions do not start with "This policy...", rather they start with a
verb.
- Policy descriptions explicitly illustrates what the policy does or does not do
if it is enabled, disabled or not configured.

The drop down is needed because an unchecked checkbox doesn't set the
corresponding registry value to "0", even with a VALUEOFF modifier. This only
works for policies at the top level. This means the template didn't allow an
administrator to specify "use this homepage URL always", because it wasn't
possible to set the HomepageIsNewTab to "0", rather then just unset.

[fmantek_google.com, 2010-06-30 08:56:56]

In that case. LGTM

On Wed, Jun 30, 2010 at 9:44 AM, <danno@chromium.org> wrote:

> Actually, I think it's better that our templates are follow the "typical
> windows" style. If the Omaha templates don't, then maybe we might want to
> address that separately.
>
>  Here are examples of the  things I changed. I observed them in the
> majority of
> the random sampling of built-in windows policies that I looked at:
>
> - No punctuation for checkbox policy elements, unless in the descriptive
> text
> before. Colon after label on elements for everything else (e.g. drop-downs,
> edit
> text fields)
> - Descriptions do not start with "This policy...", rather they start with a
> verb.
> - Policy descriptions explicitly illustrates what the policy does or does
> not do
> if it is enabled, disabled or not configured.
>
> The drop down is needed because an unchecked checkbox doesn't set the
> corresponding registry value to "0", even with a VALUEOFF modifier. This
> only
> works for policies at the top level. This means the template didn't allow
> an
> administrator to specify "use this homepage URL always", because it wasn't
> possible to set the HomepageIsNewTab to "0", rather then just unset.
>
>
> http://codereview.chromium.org/2806040/show
>