Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 280603002: Disable ProfileListDesktopBrowserTest on Chrome OS since it has different multi-profiles UI (Closed)

Created:
6 years, 7 months ago by Nikita (slow)
Modified:
6 years, 7 months ago
Reviewers:
rpetterson
CC:
chromium-reviews
Visibility:
Public.

Description

Disable ProfileListDesktopBrowserTest on Chrome OS since it has different multi-profiles UI BUG=351245 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269938

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M chrome/browser/profiles/profile_list_desktop_browsertest.cc View 2 chunks +13 lines, -2 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Nikita (slow)
Rachel, please take a look.
6 years, 7 months ago (2014-05-12 16:45:56 UTC) #1
rpetterson
LGTM https://codereview.chromium.org/280603002/diff/1/chrome/browser/profiles/profile_list_desktop_browsertest.cc File chrome/browser/profiles/profile_list_desktop_browsertest.cc (right): https://codereview.chromium.org/280603002/diff/1/chrome/browser/profiles/profile_list_desktop_browsertest.cc#newcode55 chrome/browser/profiles/profile_list_desktop_browsertest.cc:55: #elif defined(OS_CHROMEOS) I've always seen that the disables ...
6 years, 7 months ago (2014-05-12 17:53:55 UTC) #2
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 7 months ago (2014-05-12 18:48:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/280603002/1
6 years, 7 months ago (2014-05-12 18:48:52 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-12 22:28:08 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 00:41:34 UTC) #6
Message was sent while issue was closed.
Change committed as 269938

Powered by Google App Engine
This is Rietveld 408576698