Run all the pngs in chrome/app/theme/ through pngcrush.
- Re-compresses all the image data, average savings 1%-4% in filesize.
- Removes the "Created with Adobe Whatever" string from all PNGs, shrinking
the files marginally even when the image data was already optimal.
This shaves more than 100k off of chrome.pak.
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50754
10 years, 6 months ago
(2010-06-24 18:08:57 UTC)
#1
Glen Murphy
PNGCrush makes designers cry, as it makes the images mostly uneditable, which means small changes ...
10 years, 6 months ago
(2010-06-24 18:51:45 UTC)
#2
PNGCrush makes designers cry, as it makes the images mostly uneditable, which
means small changes require everything has to be rebuilt from source, which
makes designers cry.
However, screw those guys. LGTM.
Evan Martin
It would be nice to check in the "source" images if they exist somewhere...
10 years, 6 months ago
(2010-06-24 19:39:03 UTC)
#3
It would be nice to check in the "source" images if they exist somewhere...
tony
On 2010/06/24 19:39:03, Evan Martin wrote: > It would be nice to check in the ...
10 years, 6 months ago
(2010-06-25 00:31:02 UTC)
#4
On 2010/06/24 19:39:03, Evan Martin wrote:
> It would be nice to check in the "source" images if they exist somewhere...
In the past, we talked about adding pngcrush to the build, so we don't have to
remember to run it every few months. However, I think we decided against it
because it slows down clean compiles. *shrug* Personally, I wouldn't mind
adding it as a build rule (it should only run for clean builds) . . .
Issue 2806029: Run all the pngs in chrome/app/theme/ through pngcrush.
(Closed)
Created 10 years, 6 months ago by Elliot Glaysher
Modified 9 years, 7 months ago
Reviewers: glen, Evan Martin, Glen Murphy, tony
Base URL: http://src.chromium.org/git/chromium.git
Comments: 0