Issue 2806006: Fix build for remoting

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2806006: Fix build for remoting (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 11 months ago by Alpha Left Google

Modified:
3 years, 11 months ago

Reviewers:
Sergey Ulanov, dmac, dimich

CC:
chromium-reviews, awong (On leave), garykac, Alpha Left Google

Visibility:
Public.

Description

Fix build for remoting Remoting turned on -Wall, causing some compilation failures. TBR=dmaclach, dimich Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49882

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

LGTM http://codereview.chromium.org/2806006/diff/1/2 File remoting/jingle_glue/jingle_test_client.cc (right): http://codereview.chromium.org/2806006/diff/1/2#newcode5 remoting/jingle_glue/jingle_test_client.cc:5: #include "build/build_config.h" Please also remove this include. http://codereview.chromium.org/2806006/diff/1/2#newcode9 ...

4 years, 11 months ago (2010-06-16 01:26:25 UTC) #2

dmac

4 years, 11 months ago (2010-06-16 03:15:43 UTC) #3

LGTM++ with sergey's comments.

On 2010/06/16 01:26:25, sergeyu wrote:
> LGTM
> 
> http://codereview.chromium.org/2806006/diff/1/2
> File remoting/jingle_glue/jingle_test_client.cc (right):
> 
> http://codereview.chromium.org/2806006/diff/1/2#newcode5
> remoting/jingle_glue/jingle_test_client.cc:5: #include "build/build_config.h"
> Please also remove this include.
> 
> http://codereview.chromium.org/2806006/diff/1/2#newcode9
> remoting/jingle_glue/jingle_test_client.cc:9: #include <unistd.h>
> and this.

Expand Messages | Collapse Messages

Issue 2806006: Fix build for remoting (Closed)

Description

Patch Set 1 #

Messages