Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Unified Diff: components/signin/core/browser/signin_header_helper_unittest.cc

Issue 2805843003: Network traffic annotation added to components/ unittests. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/previews/core/previews_io_data_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/signin/core/browser/signin_header_helper_unittest.cc
diff --git a/components/signin/core/browser/signin_header_helper_unittest.cc b/components/signin/core/browser/signin_header_helper_unittest.cc
index 09d66c784c018c37b5be4919cc158edb6823e984..1c67727627d5a0135c18ab30eee228ee5a611285 100644
--- a/components/signin/core/browser/signin_header_helper_unittest.cc
+++ b/components/signin/core/browser/signin_header_helper_unittest.cc
@@ -10,6 +10,7 @@
#include "components/signin/core/browser/signin_header_helper.h"
#include "components/signin/core/common/signin_switches.h"
#include "components/sync_preferences/testing_pref_service_syncable.h"
+#include "net/traffic_annotation/network_traffic_annotation_test_helper.h"
#include "net/url_request/url_request_test_util.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
@@ -42,7 +43,8 @@ class SigninHeaderHelperTest : public testing::Test {
const std::string& expected_request) {
bool expected_result = !expected_request.empty();
std::unique_ptr<net::URLRequest> url_request =
- url_request_context_.CreateRequest(url, net::DEFAULT_PRIORITY, nullptr);
+ url_request_context_.CreateRequest(url, net::DEFAULT_PRIORITY, nullptr,
+ TRAFFIC_ANNOTATION_FOR_TESTS);
EXPECT_EQ(signin::AppendOrRemoveMirrorRequestHeaderIfPossible(
url_request.get(), GURL(), account_id, cookie_settings_.get(),
signin::PROFILE_MODE_DEFAULT),
@@ -153,7 +155,8 @@ TEST_F(SigninHeaderHelperTest, TestMirrorHeaderEligibleRedirectURL) {
const GURL redirect_url("https://www.google.com");
const std::string account_id = "0123456789";
std::unique_ptr<net::URLRequest> url_request =
- url_request_context_.CreateRequest(url, net::DEFAULT_PRIORITY, nullptr);
+ url_request_context_.CreateRequest(url, net::DEFAULT_PRIORITY, nullptr,
+ TRAFFIC_ANNOTATION_FOR_TESTS);
EXPECT_TRUE(signin::AppendOrRemoveMirrorRequestHeaderIfPossible(
url_request.get(), redirect_url, account_id, cookie_settings_.get(),
signin::PROFILE_MODE_DEFAULT));
@@ -171,7 +174,8 @@ TEST_F(SigninHeaderHelperTest, TestMirrorHeaderNonEligibleRedirectURL) {
const GURL redirect_url("http://www.foo.com");
const std::string account_id = "0123456789";
std::unique_ptr<net::URLRequest> url_request =
- url_request_context_.CreateRequest(url, net::DEFAULT_PRIORITY, nullptr);
+ url_request_context_.CreateRequest(url, net::DEFAULT_PRIORITY, nullptr,
+ TRAFFIC_ANNOTATION_FOR_TESTS);
EXPECT_FALSE(signin::AppendOrRemoveMirrorRequestHeaderIfPossible(
url_request.get(), redirect_url, account_id, cookie_settings_.get(),
signin::PROFILE_MODE_DEFAULT));
@@ -190,7 +194,8 @@ TEST_F(SigninHeaderHelperTest, TestIgnoreMirrorHeaderNonEligibleURLs) {
const std::string account_id = "0123456789";
const std::string fake_header = "foo,bar";
std::unique_ptr<net::URLRequest> url_request =
- url_request_context_.CreateRequest(url, net::DEFAULT_PRIORITY, nullptr);
+ url_request_context_.CreateRequest(url, net::DEFAULT_PRIORITY, nullptr,
+ TRAFFIC_ANNOTATION_FOR_TESTS);
url_request->SetExtraRequestHeaderByName(signin::kChromeConnectedHeader,
fake_header, false);
EXPECT_FALSE(signin::AppendOrRemoveMirrorRequestHeaderIfPossible(
« no previous file with comments | « components/previews/core/previews_io_data_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698