third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp - Issue 2805823003: Remove DCHECK_IS_ON() condition check around *.isGraphOwner() method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp

Issue 2805823003: Remove DCHECK_IS_ON() condition check around *.isGraphOwner() method (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp b/third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp

index 3e3e9e79c715dea4bd1c91717a440aaca9d88abe..f1e7ff71617f931bcf35a05242e0caea58f7196b 100644

--- a/third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp

@@ -141,9 +141,7 @@ void AnalyserHandler::setSmoothingTimeConstant(double k,

}

void AnalyserHandler::updatePullStatus() {

-#if DCHECK_IS_ON()

DCHECK(context()->isGraphOwner());

-#endif

if (output(0).isConnected()) {

// When an AudioBasicInspectorNode is connected to a downstream node, it