Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/audio-scheduled-source-basic.html

Issue 2805773002: Implement ownProperty() and inheritFrom() assertions in should() (Closed)
Patch Set: Addressing feedback Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/webaudio/resources/audit.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/webaudio/audio-scheduled-source-basic.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/audio-scheduled-source-basic.html b/third_party/WebKit/LayoutTests/webaudio/audio-scheduled-source-basic.html
index d67350dbed186be512c7cd442a3fbbc01b8bd030..751effe608230bea78059def4ac5932cb4aad86b 100644
--- a/third_party/WebKit/LayoutTests/webaudio/audio-scheduled-source-basic.html
+++ b/third_party/WebKit/LayoutTests/webaudio/audio-scheduled-source-basic.html
@@ -36,22 +36,17 @@
// AudioScheduledSourceNode must have these properties.
for (p in expectedProperties) {
- should(
- AudioScheduledSourceNode.prototype.hasOwnProperty(
- expectedProperties[p]),
- 'AudioScheduledSourceNode.' + expectedProperties[p])
- .beTrue();
+ should(AudioScheduledSourceNode.prototype,
+ 'AudioScheduledSourceNode.prototype')
+ .haveOwnProperty(expectedProperties[p]);
}
// ConstantSource and Oscillator must not
var nodes = ['ConstantSourceNode', 'OscillatorNode'];
for (n in nodes) {
for (p in expectedProperties) {
- should(
- window[nodes[n]].prototype.hasOwnProperty(
- expectedProperties[p]),
- nodes[n] + '.' + expectedProperties[p])
- .beFalse();
+ should(window[nodes[n]].prototype, nodes[n] + '.prototype')
+ .notHaveOwnProperty(expectedProperties[p]);
}
}
@@ -59,18 +54,15 @@
// have the others.
for (p in expectedProperties) {
if (expectedProperties[p] !== 'start') {
- should(
- AudioBufferSourceNode.prototype.hasOwnProperty(
- expectedProperties[p]),
- 'AudioBufferSourceNode.' + expectedProperties[p])
- .beFalse();
+ should(AudioBufferSourceNode.prototype,
+ 'AudioBufferSourceNode.prototype')
+ .notHaveOwnProperty(expectedProperties[p]);
}
}
- should(
- AudioBufferSourceNode.prototype.hasOwnProperty('start'),
- 'AudioBufferSourceNode.start')
- .beTrue();
+ should(AudioBufferSourceNode.prototype,
+ 'AudioBufferSourceNode.prototype')
+ .haveOwnProperty('start');
task.done();
});
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/webaudio/resources/audit.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698