[System-Keyboard-Lock] Forward navigator functions to RenderFrameHost

content/common/frame.mojom

Index: content/common/frame.mojom
diff --git a/content/common/frame.mojom b/content/common/frame.mojom
index affcff1f5cbb82374823444bcbd30a46388c8e84..d8521c8ae7a46662a50c9bc41bc830498816bf8a 100644
--- a/content/common/frame.mojom
+++ b/content/common/frame.mojom
@@ -4,6 +4,8 @@
 
 module content.mojom;
 
+import "mojo/common/string16.mojom";
+
 import "services/service_manager/public/interfaces/interface_provider.mojom";
 
 // The name of the InterfaceProviderSpec in service manifests used by the
@@ -28,6 +30,11 @@ interface FrameBindingsControl {
 // Implemented by the frame server (i.e. the browser process).
 interface FrameHost {
   GetInterfaceProvider(service_manager.mojom.InterfaceProvider& interfaces);
+
+  RequestKeyLock(array<string> key_codes)

[whywhat, 2017/04/11 14:52:33]

I think the intention here is for various APIs to live under their own Mojo
interfaces that FrameHost interface allows the renderer to acquire via
GetInterfaceProvider above - see RegisterMojoInterfaces in RenderFrameHostImpl
and how various mojo services registered there are implemented.

[Hzj_jie, 2017/04/12 02:51:05]

Got you, thank you.
The code has been updated.

+    => (bool allowed_by_user_or_browser, mojo.common.mojom.String16 reason);
+
+  CancelKeyLock() => ();

[whywhat, 2017/04/11 14:52:33]

nit: I believe you can just omit => () if it's not used?

[Hzj_jie, 2017/04/12 02:51:05]

The plan is to let browser tell renderer the finish of this function, though for
now we do not actively export the result to the web page.
These APIs are still under discussing, some users require the callback (promise
v.s. void) of the navigator.cancelKeyLock(), so I would ensure in most of the
design, the signal is correctly posted.

 };
 
 // Implemented by a service that provides implementations of the Frame