OLD | NEW |
---|---|
(Empty) | |
1 // Copyright 2017 The Chromium Authors. All rights reserved. | |
2 // Use of this source code is governed by a BSD-style license that can be | |
3 // found in the LICENSE file. | |
4 | |
5 #include "content/browser/keyboard_lock/keyboard_lock_service_impl.h" | |
6 | |
7 #include "content/public/browser/render_frame_host.h" | |
8 | |
9 namespace content { | |
10 | |
11 KeyboardLockServiceImpl::KeyboardLockServiceImpl( | |
12 blink::mojom::KeyboardLockServiceRequest request) | |
13 : binding_(this, std::move(request)) {} | |
dcheng
2017/04/26 13:27:17
Nit: #include <utility>
Hzj_jie
2017/04/26 22:05:56
Done.
| |
14 | |
15 KeyboardLockServiceImpl::~KeyboardLockServiceImpl() = default; | |
16 | |
17 // static | |
18 void KeyboardLockServiceImpl::CreateMojoService( | |
19 RenderFrameHost* render_frame_host, | |
20 blink::mojom::KeyboardLockServiceRequest request) { | |
21 new KeyboardLockServiceImpl(std::move(request)); | |
dcheng
2017/04/26 13:27:17
Is this leaked? The binding isn't a strong binding
Hzj_jie
2017/04/26 22:05:56
I do not think so: the object is owned by binding_
dcheng
2017/04/27 02:53:10
Talked offline and we agree that this needs to be
Hzj_jie
2017/04/28 00:10:31
Done.
| |
22 } | |
23 | |
24 void KeyboardLockServiceImpl::RequestKeyLock( | |
25 const std::vector<std::string>& key_codes, | |
26 const RequestKeyLockCallback& callback) { | |
27 // TODO(zijiehe): Implementation required. | |
dcheng
2017/04/26 13:27:17
For IPC reviews, it's generally beneficial to incl
Hzj_jie
2017/04/26 22:05:56
I'd only say we still have bunch of changes needed
dcheng
2017/04/27 02:53:10
Please include an IPC security reviewer on the fol
Hzj_jie
2017/04/28 00:10:31
Done.
| |
28 callback.Run(true, std::string()); | |
29 } | |
30 | |
31 void KeyboardLockServiceImpl::CancelKeyLock() { | |
32 // TODO(zijiehe): Implementation required. | |
33 } | |
34 | |
35 } // namespace content | |
OLD | NEW |