third_party/WebKit/Source/modules/keyboard_lock/OWNERS - Issue 2805763004: [System-Keyboard-Lock] Forward navigator functions to RenderFrameHost

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/keyboard_lock/OWNERS

Issue 2805763004: [System-Keyboard-Lock] Forward navigator functions to RenderFrameHost (Closed)

Patch Set: Resolve review comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/keyboard_lock/NavigatorKeyboardLock.h ('K') | « third_party/WebKit/Source/modules/keyboard_lock/NavigatorKeyboardLock.idl ('k') | third_party/WebKit/Source/modules/modules_idl_files.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 zijiehe@chromium.org
	foolip 2017/04/18 05:10:57 How about garykac@chromium.org and jamiewalch@chro How about garykac@chromium.org and jamiewalch@chromium.org? As editors of the spec, they should be the best reviewers of this code after you. haraken 2017/04/18 07:38:36 modules/ have serious code health issues and we've Show quoted text On 2017/04/18 05:10:57, foolip OOO on Wednesday wrote: > How about mailto:garykac@chromium.org and mailto:jamiewalch@chromium.org? As editors of the > spec, they should be the best reviewers of this code after you. modules/ have serious code health issues and we've been trying not to add persons to OWNERS until they get familiar with Blink's implementation. (I should document this somewhere.) Hzj_jie 2017/04/19 00:45:55 I am happy to entirely remove this OWNER file, if Show quoted text On 2017/04/18 07:38:36, haraken wrote: > On 2017/04/18 05:10:57, foolip OOO on Wednesday wrote: > > How about mailto:garykac@chromium.org and mailto:jamiewalch@chromium.org? As > editors of the > > spec, they should be the best reviewers of this code after you. > > modules/ have serious code health issues and we've been trying not to add > persons to OWNERS until they get familiar with Blink's implementation. (I should > document this somewhere.) I am happy to entirely remove this OWNER file, if it's not a must-have. I see 74 folders under modules, but only 66 of them have OWNERS file. Otherwise, I am also OK to add GaryKac@ and JamieWalch@ to it, though the COMPONENT: Services>Chromoting has covered them already.
	2

	3 # COMPONENT: Services>Chromoting

OLD	NEW