third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/navigator-cancelKeyLock.https.html - Issue 2805763004: [System-Keyboard-Lock] Forward navigator functions to RenderFrameHost

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/navigator-cancelKeyLock.https.html

Issue 2805763004: [System-Keyboard-Lock] Forward navigator functions to RenderFrameHost (Closed)

Patch Set: Resolve review comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="/resources/testharness.js"></script>

	3 <script src="/resources/testharnessreport.js"></script>

	4 <script>

	5 'use strict';

	6

	7 test(() => {

	8 assert_true(navigator.cancelKeyLock() === undefined);
	foolip 2017/04/18 05:10:57 assert_equals(navigator.cancelKeyLock(), undefined assert_equals(navigator.cancelKeyLock(), undefined); Could also split into two lines so that the two kinds of failures possible are on different lines, although one would be able to tell why it failed anyway. Hzj_jie 2017/04/19 00:45:55 Done. Show quoted text On 2017/04/18 05:10:57, foolip OOO on Wednesday wrote: > assert_equals(navigator.cancelKeyLock(), undefined); > > Could also split into two lines so that the two kinds of failures possible are > on different lines, although one would be able to tell why it failed anyway. Done.
	9 }, 'Keyboard Lock cancelKeyLock');

	10

	11 </script>

OLD	NEW