third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/idl-KeyboardLock.https.html - Issue 2805763004: [System-Keyboard-Lock] Forward navigator functions to RenderFrameHost

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/idl-KeyboardLock.https.html

Issue 2805763004: [System-Keyboard-Lock] Forward navigator functions to RenderFrameHost (Closed)

Patch Set: Resolve review comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Keyboard Lock - Interface</title>

	3 <script src="/resources/testharness.js"></script>

	4 <script src="/resources/testharnessreport.js"></script>

	5 <script>

	6 'use strict';

	7

	8 test(() => {

	9 // Navigator has both requestKeyLock() and cancelKeyLock() functions.
	foolip 2017/04/18 05:10:57 This should now be covered by the idlharness.js te This should now be covered by the idlharness.js test. Can you fold what remains of this test into the requestKeyLock() test? Hzj_jie 2017/04/20 21:23:57 Done. Show quoted text On 2017/04/18 05:10:57, foolip_UTC7 wrote: > This should now be covered by the idlharness.js test. Can you fold what remains > of this test into the requestKeyLock() test? Done.
	10 assert_true('requestKeyLock' in navigator);

	11 assert_true('cancelKeyLock' in navigator);

	12 assert_equals(typeof(navigator.requestKeyLock), 'function');

	13 assert_equals(typeof(navigator.cancelKeyLock), 'function');

	14 const p = navigator.requestKeyLock();

	15 assert_equals(typeof(p.then), 'function');

	16 assert_equals(typeof(p.catch), 'function');

	17 }, 'Keyboard Lock IDL test');

	18

	19 </script>

OLD	NEW