third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/idlharness.https.html - Issue 2805763004: [System-Keyboard-Lock] Forward navigator functions to RenderFrameHost

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/idlharness.https.html

Issue 2805763004: [System-Keyboard-Lock] Forward navigator functions to RenderFrameHost (Closed)

Patch Set: Sync latest changes Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/idl-KeyboardLock.https.html ('k') | third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/navigator-cancelKeyLock.https.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>
	Hzj_jie 2017/04/18 02:26:08 It's weird: this test won't be executed on my mach It's weird: this test won't be executed on my machine. foolip 2017/04/18 05:10:57 Were you using run-webkit-tests? After running it Show quoted text On 2017/04/18 02:26:08, Hzj_jie wrote: > It's weird: this test won't be executed on my machine. Were you using run-webkit-tests? After running it and this test didn't run, can you check if the generated MANIFEST.json includes this file? Hzj_jie 2017/04/19 00:45:55 Done. Show quoted text On 2017/04/18 05:10:57, foolip OOO on Wednesday wrote: > On 2017/04/18 02:26:08, Hzj_jie wrote: > > It's weird: this test won't be executed on my machine. > > Were you using run-webkit-tests? After running it and this test didn't run, can > you check if the generated MANIFEST.json includes this file? Done.
	2 <html>

	3 <head>

	4 <title>Keyboard Lock IDL tests</title>

	5 <link rel="help" href="https://garykac.github.io/system-keyboard-lock/">

	6 <script src="../../../resources/testharness.js"></script>
	foolip 2017/04/18 05:10:57 Not sure, but this may be the reason that the test Not sure, but this may be the reason that the test isn't run. Try absolute paths here, /resources/testharness.js Hzj_jie 2017/04/19 00:45:55 Oh, yes, that's the reason. Updated. Sorry, I ver Show quoted text On 2017/04/18 05:10:57, foolip OOO on Wednesday wrote: > Not sure, but this may be the reason that the test isn't run. Try absolute paths > here, /resources/testharness.js Oh, yes, that's the reason. Updated. Sorry, I verified this file on my local machine, I do not need to start an http server by using relative URLs. Another error is raised, requestKeyLock(sequence) calling operation with this = null didn't throw TypeError. But the logic is in the generated file from idl. foolip 2017/04/21 06:08:32 That is very strange, and sounds like a bug. Non-s Show quoted text On 2017/04/19 00:45:55, Hzj_jie wrote: > On 2017/04/18 05:10:57, foolip OOO on Wednesday wrote: > > Not sure, but this may be the reason that the test isn't run. Try absolute > paths > > here, /resources/testharness.js > > Oh, yes, that's the reason. Updated. > > Sorry, I verified this file on my local machine, I do not need to start an http > server by using relative URLs. > > Another error is raised, requestKeyLock(sequence) calling operation with this = > null didn't throw TypeError. > But the logic is in the generated file from idl. That is very strange, and sounds like a bug. Non-static methods should require a this that's an instance of the right type (Navigator here). This might be a bug with our generated bindings, can you run that part of the test in a debugger and see where it returns from the requestKeyLock call? Or just reading the generated code in V8NavigatorKeyboardLock.cpp could reveal the reason. Hzj_jie 2017/04/22 01:20:24 The generated code looks correct, and both followi Show quoted text On 2017/04/21 06:08:32, foolip_UTC7 wrote: > On 2017/04/19 00:45:55, Hzj_jie wrote: > > On 2017/04/18 05:10:57, foolip OOO on Wednesday wrote: > > > Not sure, but this may be the reason that the test isn't run. Try absolute > > paths > > > here, /resources/testharness.js > > > > Oh, yes, that's the reason. Updated. > > > > Sorry, I verified this file on my local machine, I do not need to start an > http > > server by using relative URLs. > > > > Another error is raised, requestKeyLock(sequence) calling operation with this > = > > null didn't throw TypeError. > > But the logic is in the generated file from idl. > > That is very strange, and sounds like a bug. Non-static methods should require a > this that's an instance of the right type (Navigator here). This might be a bug > with our generated bindings, can you run that part of the test in a debugger and > see where it returns from the requestKeyLock call? Or just reading the generated > code in V8NavigatorKeyboardLock.cpp could reveal the reason. The generated code looks correct, and both following pieces of code ------------- <html> <head> <script> navigator.requestKeyLock.call(null); </script> </head> </html> ------------- <html> <head> <script> navigator.requestKeyLock.apply(null); </script> </head> </html> ------------- throws TypeError in promise as expected. I have dig it a little bit deeper, the webidl2.js does not parse the return type of requestKeyLock() function correctly or at least not as the expectation of idlharness.js. (generic == null) So I have made a change also in idlharness.js, and this test is passing.
	7 <script src="../../../resources/testharnessreport.js"></script>

	8 <script src="../../../resources/WebIDLParser.js"></script>

	9 <script src="../../../resources/idlharness.js"></script>

	10 </head>

	11 <body>

	12 <pre id="untested_idl" style="display: none">

	13 interface Navigator {

	14 };

	15 </pre>

	16 <pre id="idl" style="display: none">

	17 partial interface Navigator {

	18 [SecureContext, RuntimeEnabled=KeyboardLock, CallWith=ScriptState] Promise<voi d> requestKeyLock(optional sequence<DOMString> keyCodes);

	19 [SecureContext, RuntimeEnabled=KeyboardLock] void cancelKeyLock();

	20 };

	21 </pre>

	22 <script>

	23 var idl_array = new IdlArray();

	24 idl_array.add_untested_idls(document.getElementById("untested_idl").textContent) ;

	25 idl_array.add_idls(document.getElementById("idl").textContent);

	26 idl_array.add_objects({

	27 Navigator: ["navigator"]

	28 });

	29 idl_array.test();

	30 </script>

	31 <div id="log"></div>

	32 </body>

	33 </html>

OLD	NEW