third_party/WebKit/Source/modules/keyboard_lock/OWNERS - Issue 2805763004: [System-Keyboard-Lock] Forward navigator functions to RenderFrameHost

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/keyboard_lock/OWNERS

Issue 2805763004: [System-Keyboard-Lock] Forward navigator functions to RenderFrameHost (Closed)

Patch Set: Synchronize latest changes Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/keyboard_lock/NavigatorKeyboardLock.idl ('K') | « third_party/WebKit/Source/modules/keyboard_lock/NavigatorKeyboardLock.idl ('k') | third_party/WebKit/Source/modules/modules_idl_files.gni » ('j') | third_party/WebKit/public/platform/modules/keyboard_lock/OWNERS » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 zijiehe@chromium.org
	foolip 2017/04/17 08:46:05 Just one entry in this file and no team/component Just one entry in this file and no team/component seams like a problem, and I suppose is why I was asked to review. Can you add at least a team and component here, so that there's somebody responsible if you are on vacation, switch projects, etc? If you can find another individual owner right now, that'd be great too. haraken 2017/04/17 14:15:57 +1 to adding TEAMS and COMPONENTS. Also we normall Show quoted text On 2017/04/17 08:46:05, foolip_UTC7 wrote: > Just one entry in this file and no team/component seams like a problem, and I > suppose is why I was asked to review. Can you add at least a team and component > here, so that there's somebody responsible if you are on vacation, switch > projects, etc? If you can find another individual owner right now, that'd be > great too. +1 to adding TEAMS and COMPONENTS. Also we normally avoid adding a person to OWNERS until she commits sufficient patches. Hzj_jie 2017/04/18 02:26:08 he. Show quoted text On 2017/04/17 14:15:57, haraken wrote: > On 2017/04/17 08:46:05, foolip_UTC7 wrote: > > Just one entry in this file and no team/component seams like a problem, and I > > suppose is why I was asked to review. Can you add at least a team and > component > > here, so that there's somebody responsible if you are on vacation, switch > > projects, etc? If you can find another individual owner right now, that'd be > > great too. > > +1 to adding TEAMS and COMPONENTS. Also we normally avoid adding a person to > OWNERS until she commits sufficient patches. he. Hzj_jie 2017/04/18 02:26:08 Added COMPONENT: Services>Chromoting Show quoted text On 2017/04/17 08:46:05, foolip_UTC7 wrote: > Just one entry in this file and no team/component seams like a problem, and I > suppose is why I was asked to review. Can you add at least a team and component > here, so that there's somebody responsible if you are on vacation, switch > projects, etc? If you can find another individual owner right now, that'd be > great too. Added COMPONENT: Services>Chromoting
OLD	NEW