third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/testKeyboardLockRequest.html - Issue 2805763004: [System-Keyboard-Lock] Forward navigator functions to RenderFrameHost

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/testKeyboardLockRequest.html

Issue 2805763004: [System-Keyboard-Lock] Forward navigator functions to RenderFrameHost (Closed)

Patch Set: Synchronize latest changes Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/testKeyboardLockCancel.html ('K') | « third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/testKeyboardLockCancel.html ('k') | third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/testKeyboardLockTwoParallelRequests.html » ('j') | third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/testKeyboardLockTwoParallelRequests.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Keyboard Lock - Interface</title>

	3 <script src="/resources/testharness.js"></script>

	4 <script src="/resources/testharnessreport.js"></script>

	5 <script>

	6 'use strict';

	7

	8 promise_test(() => {

	9 return navigator.requestKeyLock(['a', 'b'])
	foolip 2017/04/17 08:46:04 Ditto about this name not being in the spec. Ditto about this name not being in the spec. Hzj_jie 2017/04/18 02:26:07 Yes, Gary is changing the spec. Show quoted text On 2017/04/17 08:46:04, foolip_UTC7 wrote: > Ditto about this name not being in the spec. Yes, Gary is changing the spec.
	10 .then(() => {})
	foolip 2017/04/17 08:46:04 I think you can omit both the .then and the .catch I think you can omit both the .then and the .catch line. If the returned promise is resolved the test will pass, and if it's rejected the test will fail, the promise_test machinery takes care of that. Hzj_jie 2017/04/18 02:26:07 Done. Show quoted text On 2017/04/17 08:46:04, foolip_UTC7 wrote: > I think you can omit both the .then and the .catch line. If the returned promise > is resolved the test will pass, and if it's rejected the test will fail, the > promise_test machinery takes care of that. Done.
	11 .catch((reason) => {

	12 assert_true(false, 'requestKeyLock should succeed: ' + reason);

	13 });

	14 }, 'Keyboard Lock requestKeyLock test');
	foolip 2017/04/17 08:46:04 Ditto about having just one title in the file. Ditto about having just one title in the file. Hzj_jie 2017/04/18 02:26:08 Done. Show quoted text On 2017/04/17 08:46:04, foolip_UTC7 wrote: > Ditto about having just one title in the file. Done.
	15

	16 </script>

OLD	NEW