third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/idl-KeyboardLock.html - Issue 2805763004: [System-Keyboard-Lock] Forward navigator functions to RenderFrameHost

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/idl-KeyboardLock.html

Issue 2805763004: [System-Keyboard-Lock] Forward navigator functions to RenderFrameHost (Closed)

Patch Set: Synchronize latest changes Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json ('K') | « third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json ('k') | third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/testKeyboardLockCancel.html » ('j') | third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/testKeyboardLockCancel.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Keyboard Lock - Interface</title>

	3 <script src="/resources/testharness.js"></script>

	4 <script src="/resources/testharnessreport.js"></script>

	5 <script>

	6 'use strict';

	7

	8 test(() => {

	9 // NavigatorKeyboardLock implements both requestKeyLock() and cancelKeyLock()
	foolip 2017/04/17 08:46:04 NavigatorKeyboardLock is just the name of the Blin NavigatorKeyboardLock is just the name of the Blink IDL file, in the spec it's just a partial interface. So, you could s/NavigatorKeyboardLock implements/Navigator has/, but better still to write an idlharness.js test that will take care of the mere existence tests. Here are some you can copy from: https://github.com/w3c/web-platform-tests/blob/master/battery-status/battery-... https://github.com/w3c/web-platform-tests/blob/master/gamepad/idlharness.html https://github.com/w3c/web-platform-tests/blob/master/mediasession/idlharness... https://github.com/w3c/web-platform-tests/blob/master/vibration/idl.html (a bit atypical) https://github.com/w3c/web-platform-tests/blob/master/webauthn/interfaces.htt... Because of [SecureContext], you will need to name it .https.html Hzj_jie* 2017/04/18 02:26:07 Done. Show quoted text On 2017/04/17 08:46:04, foolip_UTC7 wrote: > NavigatorKeyboardLock is just the name of the Blink IDL file, in the spec it's > just a partial interface. So, you could s/NavigatorKeyboardLock > implements/Navigator has/, but better still to write an idlharness.js test that > will take care of the mere existence tests. Here are some you can copy from: > https://github.com/w3c/web-platform-tests/blob/master/battery-status/battery-... > https://github.com/w3c/web-platform-tests/blob/master/gamepad/idlharness.html > https://github.com/w3c/web-platform-tests/blob/master/mediasession/idlharness... > https://github.com/w3c/web-platform-tests/blob/master/vibration/idl.html (a bit > atypical) > https://github.com/w3c/web-platform-tests/blob/master/webauthn/interfaces.htt... > > Because of [SecureContext], you will need to name it *.https.html Done.
	10 // functions;

	11 assert_true('requestKeyLock' in navigator);

	12 assert_true('cancelKeyLock' in navigator);

	13 assert_equals(typeof(navigator.requestKeyLock), 'function');

	14 assert_equals(typeof(navigator.cancelKeyLock), 'function');

	15 const p = navigator.requestKeyLock([]);
	foolip 2017/04/17 08:46:04 The argument is optional, omit it here so that Typ The argument is optional, omit it here so that TypeError is thrown if it's incorrectly required by an implementation. (This is the bit of the test that cannot be done using idlharness.js) Hzj_jie 2017/04/18 02:26:07 Done. Show quoted text On 2017/04/17 08:46:04, foolip_UTC7 wrote: > The argument is optional, omit it here so that TypeError is thrown if it's > incorrectly required by an implementation. (This is the bit of the test that > cannot be done using idlharness.js) Done.
	16 assert_equals(typeof(p.then), 'function');

	17 assert_equals(typeof(p.catch), 'function');

	18 }, 'Keyboard Lock IDL test');

	19

	20 </script>

OLD	NEW