[System-Keyboard-Lock] Forward navigator functions to RenderFrameHost

content/browser/keyboard_lock/keyboard_lock_service_impl.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/keyboard_lock/keyboard_lock_service_impl.h"
+
+#include "content/public/browser/render_frame_host.h"
+
+namespace content {
+
+KeyboardLockServiceImpl::KeyboardLockServiceImpl() = default;
+KeyboardLockServiceImpl::~KeyboardLockServiceImpl() = default;
+
+// static
+void KeyboardLockServiceImpl::CreateMojoService(
+    RenderFrameHost* render_frame_host,
+    blink::mojom::KeyboardLockServiceRequest request) {
+  KeyboardLockServiceImpl* impl = new KeyboardLockServiceImpl();
+  impl->binding_.reset(new mojo::Binding<blink::mojom::KeyboardLockService>(

[dcheng, 2017/04/17 23:07:52]

Then here, you can call Bind(std::move(request))

[Hzj_jie, 2017/04/18 02:26:07]

If the last sentence before this "Then here" is in the comment of
keyboard_lock_service_impl.h, this comment has been addressed.

+      impl, std::move(request)));
+}
+
+void KeyboardLockServiceImpl::RequestKeyLock(
+    const std::vector<std::string>& key_codes,
+    const RequestKeyLockCallback& callback) {
+  // TODO(zijiehe): Implementation required.

[dcheng, 2017/04/17 23:07:52]

Usually it's preferable not to land Mojo stubs--this ensures that the
subsequence changes that actually implement the stubs will be reviewed. Would
you be willing to split this up into two portions?

1) Implement the stubs for the Web API, along with any tests that can land with
it.
2) Land the CL with the Mojo changes, with the web portion actually calling
this?

[Hzj_jie, 2017/04/18 02:26:07]

I can surely do it, but AFAICT, this may not work well for this feature. The
service side change (to implement these implementations) is large, and it seems
not likely to be finished in a short time. In most of the time, we would need to
use the web api to test its partial finished behavior.

Though I think the following changes do not depend on blink -- web page will
receive key events in the same way as other keys, I can still involve you to the
CLs if you prefer.

+  callback.Run(true, std::string());
+}
+
+void KeyboardLockServiceImpl::CancelKeyLock(
+    const CancelKeyLockCallback& callback) {
+  // TODO(zijiehe): Implementation required.
+  callback.Run();
+}
+
+}  // namespace content