third_party/WebKit/public/platform/modules/keyboard_lock/keyboard_lock.mojom - Issue 2805763004: [System-Keyboard-Lock] Forward navigator functions to RenderFrameHost

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/public/platform/modules/keyboard_lock/keyboard_lock.mojom

Issue 2805763004: [System-Keyboard-Lock] Forward navigator functions to RenderFrameHost (Closed)

Patch Set: Add external/wpt tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module blink.mojom;

	6

	7 interface KeyboardLockService {
	whywhat 2017/04/12 16:02:13 nit: add some comments to the interface and method nit: add some comments to the interface and methods about the params and returns? Hzj_jie 2017/04/13 00:38:54 Updated. But in Chrome, we never reject the reques Show quoted text On 2017/04/12 16:02:13, whywhat wrote: > nit: add some comments to the interface and methods about the params and > returns? Updated. But in Chrome, we never reject the request unless the web page is out of security context. So I cannot give a very clear description about the potential strings for the \|reason\| parameter.
	8 RequestKeyLock(array<string> key_codes)

	9 => (bool allowed_by_user_or_browser, string reason);

	10

	11 CancelKeyLock() => ();

	12 };

OLD	NEW