third_party/WebKit/Source/modules/keyboard_lock/NavigatorKeyboardLock.idl - Issue 2805763004: [System-Keyboard-Lock] Forward navigator functions to RenderFrameHost

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/keyboard_lock/NavigatorKeyboardLock.idl

Issue 2805763004: [System-Keyboard-Lock] Forward navigator functions to RenderFrameHost (Closed)

Patch Set: Add external/wpt tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/keyboard_lock/NavigatorKeyboardLock.cpp ('K') | « third_party/WebKit/Source/modules/keyboard_lock/NavigatorKeyboardLock.cpp ('k') | third_party/WebKit/Source/modules/keyboard_lock/OWNERS » ('j') | third_party/WebKit/public/platform/modules/keyboard_lock/keyboard_lock.mojom » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 partial interface Navigator {
	whywhat 2017/04/12 16:02:13 nit: put a comment above the interface with at lea nit: put a comment above the interface with at least a link to the spec this idl implements. Hzj_jie 2017/04/13 00:38:54 The spec is still under discussion; should I use a Show quoted text On 2017/04/12 16:02:13, whywhat wrote: > nit: put a comment above the interface with at least a link to the spec this idl > implements. The spec is still under discussion; should I use a bug? whywhat 2017/04/13 02:34:36 I thought you can just point to https://garykac.gi Show quoted text On 2017/04/13 at 00:38:54, Hzj_jie wrote: > On 2017/04/12 16:02:13, whywhat wrote: > > nit: put a comment above the interface with at least a link to the spec this idl > > implements. > > The spec is still under discussion; should I use a bug? I thought you can just point to https://garykac.github.io/system-keyboard-lock/ You can update it later if/when it moves. Hzj_jie 2017/04/13 22:24:24 Done. Show quoted text On 2017/04/13 02:34:36, whywhat wrote: > On 2017/04/13 at 00:38:54, Hzj_jie wrote: > > On 2017/04/12 16:02:13, whywhat wrote: > > > nit: put a comment above the interface with at least a link to the spec this > idl > > > implements. > > > > The spec is still under discussion; should I use a bug? > > I thought you can just point to https://garykac.github.io/system-keyboard-lock/ > You can update it later if/when it moves. Done.
	6 [RuntimeEnabled=KeyboardLock, CallWith=ScriptState] Promise<void> requestKey Lock(DOMString[] keyCodes);

	7 [RuntimeEnabled=KeyboardLock] void cancelKeyLock();

	8 };

OLD	NEW