content/test/data/keyboard_lock/cancel_keylock.html - Issue 2805763004: [System-Keyboard-Lock] Forward navigator functions to RenderFrameHost

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/keyboard_lock/cancel_keylock.html

Issue 2805763004: [System-Keyboard-Lock] Forward navigator functions to RenderFrameHost (Closed)

Patch Set: Resolve review comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <title>Cancel keyboard lock test</title>

	4 <script type="text/javascript" src="cancel_keylock.js"></script>
	whywhat 2017/04/11 14:52:33 I think you can just put all the test code into on I think you can just put all the test code into one .html file and call different functions (like testCancelKeylock() and testRequestKeylock()) in the browser test. There's no need to have separate .js files as they are not shared between the tests and the html files are 99% the same. Hzj_jie 2017/04/12 02:51:05 Oh, I thought it's a common requirement to do so. Show quoted text On 2017/04/11 14:52:33, whywhat wrote: > I think you can just put all the test code into one .html file and call > different functions (like testCancelKeylock() and testRequestKeylock()) in the > browser test. > There's no need to have separate .js files as they are not shared between the > tests and the html files are 99% the same. Oh, I thought it's a common requirement to do so.
	5 </head>

	6 <body onload="test()">

	7 <div id="result"></div>

	8 </body>

	9 </html>

OLD	NEW