Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1676)

Unified Diff: content/child/web_url_loader_impl.cc

Issue 2805693002: PlzNavigate: add DumpWithoutCrashing for invalid main resource request. (Closed)
Patch Set: Add TODO. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/web_url_loader_impl.cc
diff --git a/content/child/web_url_loader_impl.cc b/content/child/web_url_loader_impl.cc
index 3b5126aea04bd0e021f38aba6e4f2318b8745f87..7d9d2c9f0c47500101e72e8d8a55a584493ef602 100644
--- a/content/child/web_url_loader_impl.cc
+++ b/content/child/web_url_loader_impl.cc
@@ -13,6 +13,7 @@
#include <vector>
#include "base/bind.h"
+#include "base/debug/dump_without_crashing.h"
#include "base/files/file_path.h"
#include "base/logging.h"
#include "base/memory/ptr_util.h"
@@ -612,6 +613,16 @@ void WebURLLoaderImpl::Context::Start(const WebURLRequest& request,
resource_request->resource_body_stream_url = stream_override_->stream_url;
}
+ // PlzNavigate: Invalid renderer main resource requests are rejected by the
+ // browser. This should not happen.
+ // TODO(arthursonzogni): Remove this when the root cause for
+ // https://crbug.com/705508 is found.
+ if (IsBrowserSideNavigationEnabled() &&
+ IsResourceTypeFrame(resource_request->resource_type) &&
+ !resource_request->resource_body_stream_url.SchemeIs(url::kBlobScheme)) {
+ base::debug::DumpWithoutCrashing();
+ }
+
const RequestExtraData empty_extra_data;
const RequestExtraData* extra_data;
if (request.getExtraData())
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698