Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

Issue 2805683002: Show "with <something>" for federated credentials in the MD settings. (Closed)
Patch Set: align Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
index cc59729aabb25087246159900ac6deced0a455f6..15c91f95e305d92b7e0ea0d0e4592daba6f1fdcf 100644
--- a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
+++ b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
@@ -117,16 +117,23 @@
</div>
<div class="username-column selectable text-elide"
id="username">[[item.loginPair.username]]</div>
- <div class="password-column">
- <!-- Password type and disabled in order to match mock. -->
- <input id="password" type="password" disabled
- value="[[getEmptyPassword_(item.numCharactersInPassword)]]">
- </input>
- <paper-icon-button id="passwordMenu" icon="cr:more-vert"
+ <div class="password-column text-elide">
+ <template is="dom-if" if="[[!item.federationText]]">
+ <!-- Password type and disabled in order to match mock. -->
+ <input id="password" type="password" disabled
+ value="[[getEmptyPassword_(item.numCharactersInPassword)]]">
+ </input>
+ </template>
+ <template is="dom-if" if="{{item.federationText}}">
Dan Beam 2017/04/21 22:16:39 why are you using {{}} (2-way binding) instead of
vasilii 2017/04/24 08:45:48 Because it was the only syntax I knew when I wrote
+ <span class="selectable text-elide">
+ {{item.federationText}}
+ </span>
+ </template>
+ </div>
+ <paper-icon-button id="passwordMenu" icon="cr:more-vert"
on-tap="onPasswordMenuTap_" title="$i18n{moreActions}"
tabindex$="[[tabIndex]]">
- </paper-icon-button>
- </div>
+ </paper-icon-button>
</div>
</template>
</iron-list>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698