Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

Issue 2805683002: Show "with <something>" for federated credentials in the MD settings. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html"> 1 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html">
2 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 2 <link rel="import" href="chrome://resources/cr_elements/icons.html">
3 <link rel="import" href="chrome://resources/html/action_link.html"> 3 <link rel="import" href="chrome://resources/html/action_link.html">
4 <link rel="import" href="chrome://resources/html/polymer.html"> 4 <link rel="import" href="chrome://resources/html/polymer.html">
5 <link rel="import" href="chrome://resources/html/i18n_behavior.html"> 5 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-list/iron-list.htm l"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-list/iron-list.htm l">
7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
8 <link rel="import" href="../controls/settings_toggle_button.html"> 8 <link rel="import" href="../controls/settings_toggle_button.html">
9 <link rel="import" href="../controls/extension_controlled_indicator.html"> 9 <link rel="import" href="../controls/extension_controlled_indicator.html">
10 <link rel="import" href="../controls/settings_toggle_button.html"> 10 <link rel="import" href="../controls/settings_toggle_button.html">
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 <div class="website-column no-min-width" title="[[item.linkUrl]]"> 110 <div class="website-column no-min-width" title="[[item.linkUrl]]">
111 <a id="originUrl" target="_blank" class="selectable no-min-width" 111 <a id="originUrl" target="_blank" class="selectable no-min-width"
112 href="[[item.linkUrl]]"> 112 href="[[item.linkUrl]]">
113 <span class="text-elide"> 113 <span class="text-elide">
114 [[item.loginPair.originUrl]] 114 [[item.loginPair.originUrl]]
115 </span> 115 </span>
116 </a> 116 </a>
117 </div> 117 </div>
118 <div class="username-column selectable text-elide" 118 <div class="username-column selectable text-elide"
119 id="username">[[item.loginPair.username]]</div> 119 id="username">[[item.loginPair.username]]</div>
120 <div class="password-column"> 120 <div class="password-column">
hcarmona 2017/04/20 19:13:40 Adding text-elide to the password-column makes tex
vasilii 2017/04/21 11:41:13 Done.
121 <!-- Password type and disabled in order to match mock. --> 121 <template is="dom-if" if="[[!item.federationText]]">
122 <input id="password" type="password" disabled 122 <!-- Password type and disabled in order to match mock. -->
123 value="[[getEmptyPassword_(item.numCharactersInPassword)]]"> 123 <input id="password" type="password" disabled
124 </input> 124 value="[[getEmptyPassword_(item.numCharactersInPassword)]]">
125 </input>
126 </template>
127 <template is="dom-if" if="{{item.federationText}}">
128 <span class="selectable text-elide">
129 {{item.federationText}}
130 </span>
131 </template>
125 <paper-icon-button id="passwordMenu" icon="cr:more-vert" 132 <paper-icon-button id="passwordMenu" icon="cr:more-vert"
126 on-tap="onPasswordMenuTap_" title="$i18n{moreActions}" 133 on-tap="onPasswordMenuTap_" title="$i18n{moreActions}"
127 tabindex$="[[tabIndex]]"> 134 tabindex$="[[tabIndex]]">
128 </paper-icon-button> 135 </paper-icon-button>
129 </div> 136 </div>
130 </div> 137 </div>
131 </template> 138 </template>
132 </iron-list> 139 </iron-list>
133 <div id="noPasswordsLabel" class="list-item" 140 <div id="noPasswordsLabel" class="list-item"
134 hidden$="[[hasSome_(savedPasswords)]]"> 141 hidden$="[[hasSome_(savedPasswords)]]">
(...skipping 30 matching lines...) Expand all
165 </div> 172 </div>
166 </template> 173 </template>
167 <div id="noExceptionsLabel" class="list-item" 174 <div id="noExceptionsLabel" class="list-item"
168 hidden$="[[hasSome_(passwordExceptions)]]"> 175 hidden$="[[hasSome_(passwordExceptions)]]">
169 $i18n{noExceptionsFound} 176 $i18n{noExceptionsFound}
170 </div> 177 </div>
171 </div> 178 </div>
172 </template> 179 </template>
173 <script src="passwords_section.js"></script> 180 <script src="passwords_section.js"></script>
174 </dom-module> 181 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698