Linux native notifications: Handle clicks and closes

chrome/browser/notifications/notification_platform_bridge_linux.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_PLATFORM_BRIDGE_LINUX_H_
 #define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_PLATFORM_BRIDGE_LINUX_H_
 
 #include <gio/gio.h>
 
 #include <unordered_map>
 
 #include "base/macros.h"
 #include "chrome/browser/notifications/notification_platform_bridge.h"
+#include "ui/base/glib/glib_signal.h"
 #include "ui/base/glib/scoped_gobject.h"
 
 class NotificationPlatformBridgeLinux : public NotificationPlatformBridge {
  public:
   explicit NotificationPlatformBridgeLinux(GDBusProxy* notification_proxy);
 
   ~NotificationPlatformBridgeLinux() override;
 
   // NotificationPlatformBridge:
   void Display(NotificationCommon::Type notification_type,
                const std::string& notification_id,
                const std::string& profile_id,
                bool is_incognito,
                const Notification& notification) override;
   void Close(const std::string& profile_id,
              const std::string& notification_id) override;
   void GetDisplayed(
       const std::string& profile_id,
       bool incognito,
       const DisplayedNotificationsCallback& callback) const override;
 
   // Called from NotifyCompleteReceiver().
   void NotifyCompleteInternal(gpointer user_data, GVariant* value);
 
  private:
   struct NotificationData;
 
   ScopedGObject<GDBusProxy> notification_proxy_;
 
+  // Used to disconnect from "g-signal" during destruction.
+  gulong proxy_signal_handler_ = 0;
+
   // A std::set<std::unique_ptr<T>> doesn't work well because
   // eg. std::set::erase(T) would require a std::unique_ptr<T>
   // argument, so the data would get double-destructed.
   template <typename T>
   using UnorderedUniqueSet = std::unordered_map<T*, std::unique_ptr<T>>;
 
   UnorderedUniqueSet<NotificationData> notifications_;
 
   // Makes the "Notify" call to D-Bus.
   void NotifyNow(uint32_t dbus_id,
                  NotificationCommon::Type notification_type,
                  const Notification& notification,
                  GCancellable* cancellable,
                  GAsyncReadyCallback callback,
                  gpointer user_data);
 
   // Makes the "CloseNotification" call to D-Bus.
   void CloseNow(uint32_t dbus_id);
 
+  void ForwardNotificationOperation(uint32_t dbus_id,
+                                    NotificationCommon::Operation operation,
+                                    int action_index);
+
+  CHROMEG_CALLBACK_3(NotificationPlatformBridgeLinux,

[Peter Beverloo, 2017/04/07 01:50:48]

Could you add some documentation on what this does? Looking at the definition of
CHROMEG_CALLBACK_3, this would end up calling
NotificationPlatformBridgeLinux::GSignalReceiver() with the sender and three
arguments arguments, but there is no method named GSignalReceiver in this class?

[Tom (Use chromium acct), 2017/04/07 18:59:52]

Done.  This declares GSignalReceiver

+                     void,
+                     GSignalReceiver,
+                     GDBusProxy*,
+                     const char*,
+                     const char*,
+                     GVariant*);
+
   NotificationData* FindNotificationData(const std::string& notification_id,
                                          const std::string& profile_id);
 
+  NotificationData* FindNotificationData(uint32_t dbus_id);
+
   DISALLOW_COPY_AND_ASSIGN(NotificationPlatformBridgeLinux);
 };
 
 #endif  // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_PLATFORM_BRIDGE_LINUX_H_