Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp

Issue 2805493002: Boolean properties for Accessibility Object Model Phase 1 (Closed)
Patch Set: Address feedback Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp b/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp
index a1524f98aaf8e9e54cde85112db4691a3aa49e11..3f52aaca53d4fb80d8ee3bc3f1d23692c5a9788b 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp
@@ -28,6 +28,7 @@
#include "modules/accessibility/AXListBoxOption.h"
+#include "core/dom/AccessibleNode.h"
#include "core/html/HTMLOptionElement.h"
#include "core/html/HTMLSelectElement.h"
#include "core/layout/LayoutObject.h"
@@ -82,7 +83,7 @@ bool AXListBoxOption::IsEnabled() const {
if (!GetNode())
return false;
- if (EqualIgnoringASCIICase(GetAttribute(aria_disabledAttr), "true"))
+ if (AOMPropertyOrARIAAttributeIsTrue(AOMBooleanProperty::kDisabled))
return false;
if (ToElement(GetNode())->hasAttribute(disabledAttr))
@@ -105,11 +106,11 @@ bool AXListBoxOption::IsSelectedOptionActive() const {
}
bool AXListBoxOption::ComputeAccessibilityIsIgnored(
- IgnoredReasons* ignored_reasons) const {
+ IgnoredReasons* ignoredReasons) const {
if (!GetNode())
return true;
- if (AccessibilityIsIgnoredByDefault(ignored_reasons))
+ if (AccessibilityIsIgnoredByDefault(ignoredReasons))
return true;
return false;

Powered by Google App Engine
This is Rietveld 408576698