third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp - Issue 2805493002: Boolean properties for Accessibility Object Model Phase 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp

Issue 2805493002: Boolean properties for Accessibility Object Model Phase 1 (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/AccessibleNode.cpp ('K') | « third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp ('k') | third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp » ('j') | third_party/WebKit/Source/modules/accessibility/AXObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp b/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp

index c4ba92f543cc10e21aa2d00a7da7f842fe57c457..037fbd3873e3743c9dad36ed871f00614aaa7396 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp

@@ -28,6 +28,7 @@

#include "modules/accessibility/AXListBoxOption.h"

+#include "core/dom/AccessibleNode.h"

#include "core/html/HTMLOptionElement.h"

#include "core/html/HTMLSelectElement.h"

#include "core/layout/LayoutObject.h"

@@ -82,7 +83,7 @@ bool AXListBoxOption::isEnabled() const {

if (!getNode())

return false;

- if (equalIgnoringASCIICase(getAttribute(aria_disabledAttr), "true"))

+ if (AOMPropertyOrARIAAttributeIsTrue(AOMBooleanProperty::kDisabled))

return false;

if (toElement(getNode())->hasAttribute(disabledAttr))