Boolean properties for Accessibility Object Model Phase 1

third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

 /*
  * Copyright (C) 2012, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 245 matching lines @@
   Element* descendant =
       element->GetTreeScope().GetElementById(active_descendant_attr);
   if (!descendant)
     return nullptr;
 
   AXObject* ax_descendant = AxObjectCache().GetOrCreate(descendant);
   return ax_descendant;
 }
 
 bool AXNodeObject::ComputeAccessibilityIsIgnored(
-    IgnoredReasons* ignored_reasons) const {
+    IgnoredReasons* ignoredReasons) const {
 #if DCHECK_IS_ON()
   // Double-check that an AXObject is never accessed before
   // it's been initialized.
-  DCHECK(initialized_);
+  DCHECK(m_initialized);
 #endif
 
   // If this element is within a parent that cannot have children, it should not
   // be exposed.
   if (IsDescendantOfLeafNode()) {
-    if (ignored_reasons)
-      ignored_reasons->push_back(
+    if (ignoredReasons)
+      ignoredReasons->push_back(
           IgnoredReason(kAXAncestorIsLeafNode, LeafNodeAncestor()));
     return true;
   }
 
   // Ignore labels that are already referenced by a control.
   AXObject* control_object = CorrespondingControlForLabelElement();
   if (control_object && control_object->IsCheckboxOrRadio() &&
       control_object->NameFromLabelElement()) {
-    if (ignored_reasons) {
+    if (ignoredReasons) {
       HTMLLabelElement* label = LabelElementContainer();
       if (label && label != GetNode()) {
         AXObject* label_ax_object = AxObjectCache().GetOrCreate(label);
-        ignored_reasons->push_back(
+        ignoredReasons->push_back(
             IgnoredReason(kAXLabelContainer, label_ax_object));
       }
 
-      ignored_reasons->push_back(IgnoredReason(kAXLabelFor, control_object));
+      ignoredReasons->push_back(IgnoredReason(kAXLabelFor, control_object));
     }
     return true;
   }
 
   Element* element = GetNode()->IsElementNode() ? ToElement(GetNode())
                                                 : GetNode()->parentElement();
   if (!GetLayoutObject() && (!element || !element->IsInCanvasSubtree()) &&
-      !EqualIgnoringASCIICase(GetAttribute(aria_hiddenAttr), "false")) {
-    if (ignored_reasons)
-      ignored_reasons->push_back(IgnoredReason(kAXNotRendered));
+      !AOMPropertyOrARIAAttributeIsFalse(AOMBooleanProperty::kHidden)) {
+    if (ignoredReasons)
+      ignoredReasons->push_back(IgnoredReason(kAXNotRendered));
     return true;
   }
 
   if (role_ == kUnknownRole) {
-    if (ignored_reasons)
-      ignored_reasons->push_back(IgnoredReason(kAXUninteresting));
+    if (ignoredReasons)
+      ignoredReasons->push_back(IgnoredReason(kAXUninteresting));
     return true;
   }
   return false;
 }
 
 static bool IsListElement(Node* node) {
   return isHTMLUListElement(*node) || isHTMLOListElement(*node) ||
          isHTMLDListElement(*node);
 }
 
 static bool IsPresentationalInTable(AXObject* parent,
-                                    HTMLElement* current_element) {
-  if (!current_element)
+                                    HTMLElement* currentElement) {
+  if (!currentElement)
     return false;
 
   Node* parent_node = parent->GetNode();
   if (!parent_node || !parent_node->IsHTMLElement())
     return false;
 
   // AXTable determines the role as checking isTableXXX.
   // If Table has explicit role including presentation, AXTable doesn't assign
   // implicit Role to a whole Table. That's why we should check it based on
   // node.
   // Normal Table Tree is that
   // cell(its role)-> tr(tr role)-> tfoot, tbody, thead(ignored role) ->
   //     table(table role).
   // If table has presentation role, it will be like
   // cell(group)-> tr(unknown) -> tfoot, tbody, thead(ignored) ->
   //     table(presentation).
-  if (IsHTMLTableCellElement(*current_element) &&
+  if (IsHTMLTableCellElement(*currentElement) &&
       isHTMLTableRowElement(*parent_node))
     return parent->HasInheritedPresentationalRole();
 
-  if (isHTMLTableRowElement(*current_element) &&
+  if (isHTMLTableRowElement(*currentElement) &&
       IsHTMLTableSectionElement(ToHTMLElement(*parent_node))) {
     // Because TableSections have ignored role, presentation should be checked
     // with its parent node.
     AXObject* table_object = parent->ParentObject();
     Node* table_node = table_object ? table_object->GetNode() : 0;
     return isHTMLTableElement(table_node) &&
            table_object->HasInheritedPresentationalRole();
   }
   return false;
 }
 
 static bool IsRequiredOwnedElement(AXObject* parent,
-                                   AccessibilityRole current_role,
-                                   HTMLElement* current_element) {
+                                   AccessibilityRole currentRole,
+                                   HTMLElement* currentElement) {
   Node* parent_node = parent->GetNode();
   if (!parent_node || !parent_node->IsHTMLElement())
     return false;
 
-  if (current_role == kListItemRole)
+  if (currentRole == kListItemRole)
     return IsListElement(parent_node);
-  if (current_role == kListMarkerRole)
+  if (currentRole == kListMarkerRole)
     return isHTMLLIElement(*parent_node);
-  if (current_role == kMenuItemCheckBoxRole || current_role == kMenuItemRole ||
-      current_role == kMenuItemRadioRole)
+  if (currentRole == kMenuItemCheckBoxRole || currentRole == kMenuItemRole ||
+      currentRole == kMenuItemRadioRole)
     return isHTMLMenuElement(*parent_node);
 
-  if (!current_element)
+  if (!currentElement)
     return false;
-  if (IsHTMLTableCellElement(*current_element))
+  if (IsHTMLTableCellElement(*currentElement))
     return isHTMLTableRowElement(*parent_node);
-  if (isHTMLTableRowElement(*current_element))
+  if (isHTMLTableRowElement(*currentElement))
     return IsHTMLTableSectionElement(ToHTMLElement(*parent_node));
 
   // In case of ListboxRole and its child, ListBoxOptionRole, inheritance of
   // presentation role is handled in AXListBoxOption because ListBoxOption Role
   // doesn't have any child.
   // If it's just ignored because of presentation, we can't see any AX tree
   // related to ListBoxOption.
   return false;
 }
 
@@ skipping 53 matching lines @@
     landmark_roles_not_allowed.insert(detailsTag);
     landmark_roles_not_allowed.insert(fieldsetTag);
     landmark_roles_not_allowed.insert(figureTag);
     landmark_roles_not_allowed.insert(tdTag);
     landmark_roles_not_allowed.insert(mainTag);
   }
   return landmark_roles_not_allowed;
 }
 
 bool AXNodeObject::IsDescendantOfElementType(
-    HashSet<QualifiedName>& tag_names) const {
+    HashSet<QualifiedName>& tagNames) const {
   if (!GetNode())
     return false;
 
   for (Element* parent = GetNode()->parentElement(); parent;
        parent = parent->parentElement()) {
-    if (tag_names.Contains(parent->TagQName()))
+    if (tagNames.Contains(parent->TagQName()))
       return true;
   }
   return false;
 }
 
 AccessibilityRole AXNodeObject::NativeAccessibilityRoleIgnoringAria() const {
   if (!GetNode())
     return kUnknownRole;
 
   // |HTMLAnchorElement| sets isLink only when it has hrefAttr.
@@ skipping 431 matching lines @@
     // searching up the chain.
     if (parent_aria_role)
       break;
   }
 
   return role;
 }
 
 void AXNodeObject::Init() {
 #if DCHECK_IS_ON()
-  DCHECK(!initialized_);
-  initialized_ = true;
+  DCHECK(!m_initialized);
+  m_initialized = true;
 #endif
   role_ = DetermineAccessibilityRole();
 }
 
 void AXNodeObject::Detach() {
   AXObject::Detach();
   node_ = nullptr;
 }
 
 void AXNodeObject::GetSparseAXAttributes(
@@ skipping 117 matching lines @@
 
 bool AXNodeObject::IsMenuButton() const {
   return RoleValue() == kMenuButtonRole;
 }
 
 bool AXNodeObject::IsMeter() const {
   return RoleValue() == kMeterRole;
 }
 
 bool AXNodeObject::IsMultiSelectable() const {
-  const AtomicString& aria_multi_selectable =
-      GetAttribute(aria_multiselectableAttr);
-  if (EqualIgnoringASCIICase(aria_multi_selectable, "true"))
-    return true;
-  if (EqualIgnoringASCIICase(aria_multi_selectable, "false"))
-    return false;
+  bool multiselectable = false;
+  if (HasAOMPropertyOrARIAAttribute(AOMBooleanProperty::kMultiselectable,
+                                    multiselectable)) {
+    return multiselectable;
+  }
 
   return isHTMLSelectElement(GetNode()) &&
          toHTMLSelectElement(*GetNode()).IsMultiple();
 }
 
 bool AXNodeObject::IsNativeCheckboxOrRadio() const {
   Node* node = this->GetNode();
   if (!isHTMLInputElement(node))
     return false;
 
@@ skipping 112 matching lines @@
 
 AccessibilityExpanded AXNodeObject::IsExpanded() const {
   if (GetNode() && isHTMLSummaryElement(*GetNode())) {
     if (GetNode()->parentNode() &&
         isHTMLDetailsElement(GetNode()->parentNode()))
       return ToElement(GetNode()->parentNode())->hasAttribute(openAttr)
                  ? kExpandedExpanded
                  : kExpandedCollapsed;
   }
 
-  const AtomicString& expanded = GetAttribute(aria_expandedAttr);
-  if (EqualIgnoringASCIICase(expanded, "true"))
-    return kExpandedExpanded;
-  if (EqualIgnoringASCIICase(expanded, "false"))
-    return kExpandedCollapsed;
+  bool expanded = false;
+  if (HasAOMPropertyOrARIAAttribute(AOMBooleanProperty::kExpanded, expanded)) {
+    return expanded ? kExpandedExpanded : kExpandedCollapsed;
+  }
 
   return kExpandedUndefined;
 }
 
 bool AXNodeObject::IsModal() const {
   if (RoleValue() != kDialogRole && RoleValue() != kAlertDialogRole)
     return false;
 
-  if (HasAttribute(aria_modalAttr)) {
-    const AtomicString& modal = GetAttribute(aria_modalAttr);
-    if (EqualIgnoringASCIICase(modal, "true"))
-      return true;
-    if (EqualIgnoringASCIICase(modal, "false"))
-      return false;
-  }
+  bool modal = false;
+  if (HasAOMPropertyOrARIAAttribute(AOMBooleanProperty::kModal, modal))
+    return modal;
 
   if (GetNode() && isHTMLDialogElement(*GetNode()))
     return ToElement(GetNode())->IsInTopLayer();
 
   return false;
 }
 
 bool AXNodeObject::IsPressed() const {
   if (!IsButton())
     return false;
@@ skipping 30 matching lines @@
 
   return !HasEditableStyle(*node);
 }
 
 bool AXNodeObject::IsRequired() const {
   Node* n = this->GetNode();
   if (n && (n->IsElementNode() && ToElement(n)->IsFormControlElement()) &&
       HasAttribute(requiredAttr))
     return ToHTMLFormControlElement(n)->IsRequired();
 
-  if (EqualIgnoringASCIICase(GetAttribute(aria_requiredAttr), "true"))
+  if (AOMPropertyOrARIAAttributeIsTrue(AOMBooleanProperty::kRequired))
     return true;
 
   return false;
 }
 
 bool AXNodeObject::CanSetFocusAttribute() const {
   Node* node = GetNode();
   if (!node)
     return false;
 
   if (IsWebArea())
     return true;
 
   // Children of elements with an aria-activedescendant attribute should be
   // focusable if they have a (non-presentational) ARIA role.
   if (!IsPresentational() && AriaRoleAttribute() != kUnknownRole &&
       AncestorExposesActiveDescendant())
     return true;
 
   // NOTE: It would be more accurate to ask the document whether
   // setFocusedNode() would do anything. For example, setFocusedNode() will do
   // nothing if the current focused node will not relinquish the focus.
   if (IsDisabledFormControl(node))
     return false;
 
   return node->IsElementNode() && ToElement(node)->SupportsFocus();
 }
 
 bool AXNodeObject::CanSetValueAttribute() const {
-  if (EqualIgnoringASCIICase(GetAttribute(aria_readonlyAttr), "true"))
+  if (AOMPropertyOrARIAAttributeIsTrue(AOMBooleanProperty::kReadOnly))
     return false;
 
   if (IsProgressIndicator() || IsSlider())
     return true;
 
   if (IsTextControl() && !IsNativeTextControl())
     return true;
 
   // Any node could be contenteditable, so isReadOnly should be relied upon
   // for this information for all elements.
@@ skipping 650 matching lines @@
   }
   for (const auto& owned_child : owned_children)
     children.push_back(owned_child);
 
   for (AXObject* child : children) {
     // Don't recurse into children that are explicitly marked as aria-hidden.
     // Note that we don't call isInertOrAriaHidden because that would return
     // true if any ancestor is hidden, but we need to be able to compute the
     // accessible name of object inside hidden subtrees (for example, if
     // aria-labelledby points to an object that's hidden).
-    if (EqualIgnoringASCIICase(child->GetAttribute(aria_hiddenAttr), "true"))
+    if (child->AOMPropertyOrARIAAttributeIsTrue(AOMBooleanProperty::kHidden))
       continue;
 
     // If we're going between two layoutObjects that are in separate
     // LayoutBoxes, add whitespace if it wasn't there already. Intuitively if
     // you have <span>Hello</span><span>World</span>, those are part of the same
     // LayoutBox so we should return "HelloWorld", but given
     // <div>Hello</div><div>World</div> the strings are in separate boxes so we
     // should return "Hello World".
     if (previous && accumulated_text.length() &&
         !IsHTMLSpace(accumulated_text[accumulated_text.length() - 1])) {
@@ skipping 1253 matching lines @@
     return String();
   return ToTextControlElement(node)->StrippedPlaceholder();
 }
 
 DEFINE_TRACE(AXNodeObject) {
   visitor->Trace(node_);
   AXObject::Trace(visitor);
 }
 
 }  // namespace blink