Reland of Set user agent type of transient item the same as pending item

ios/web/navigation/navigation_manager_impl.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/web/navigation/navigation_manager_impl.h"
 
 #include <stddef.h>
 
 #include <utility>
 
@@ skipping 152 matching lines @@
 }
 
 void NavigationManagerImpl::LoadURL(const GURL& url,
                                     const web::Referrer& referrer,
                                     ui::PageTransition type) {
   WebState::OpenURLParams params(url, referrer,
                                  WindowOpenDisposition::CURRENT_TAB, type, NO);
   delegate_->GetWebState()->OpenURL(params);
 }
 
+void NavigationManagerImpl::AddTransientItem(const GURL& url) {
+  [session_controller_ addTransientItemWithURL:url];
+
+  // TODO(crbug.com/676129): Add a DCHECK that pending item should always exists

[Eugene But (OOO till 7-30), 2017/04/05 22:05:39]

There is no need for DCHECK, because when crbug.com/676129 is fined then code
should look like this:

GetPendingItem()->GetUserAgentType() // no need to DCHECK something that will
crash anyway. In TODO comment, please explain that |item| can be null because of
the bug and the workaround should be removed.

+  // when the bug is fixed, because transient item is only supposed to be added
+  // for pending non-app-specific loads.
+  NavigationItem* item = GetPendingItem();
+  if (!item)
+    item = GetLastCommittedNonAppSpecificItem();
+  DCHECK(!item || item->GetUserAgentType() != UserAgentType::NONE);
+  if (item)

[Eugene But (OOO till 7-30), 2017/04/05 22:05:39]

When can |item| be null?

+    GetTransientItem()->SetUserAgentType(item->GetUserAgentType());
+}
+
 void NavigationManagerImpl::AddPendingItem(
     const GURL& url,
     const web::Referrer& referrer,
     ui::PageTransition navigation_type,
     NavigationInitiationType initiation_type,
     UserAgentOverrideOption user_agent_override_option) {
   [session_controller_ addPendingItem:url
                              referrer:referrer
                            transition:navigation_type
                        initiationType:initiation_type];
@@ skipping 275 matching lines @@
   const ScopedNavigationItemImplList& items = [session_controller_ items];
   while (index >= 0) {
     NavigationItem* item = items[index--].get();
     if (!client->IsAppSpecificURL(item->GetVirtualURL()))
       return item;
   }
   return nullptr;
 }
 
 }  // namespace web