Reland of Set user agent type of transient item the same as pending item

ios/web/navigation/navigation_manager_impl_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/web/navigation/navigation_manager_impl.h"
 
 #include "base/logging.h"
 #import "base/mac/scoped_nsobject.h"
 #import "ios/web/navigation/crw_session_controller+private_constructors.h"
 #import "ios/web/navigation/navigation_manager_delegate.h"
@@ skipping 663 matching lines @@
       GURL("http://www.3.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
       web::NavigationInitiationType::USER_INITIATED,
       web::NavigationManager::UserAgentOverrideOption::INHERIT);
   [session_controller() commitPendingItem];
   web::NavigationItem* item3 = navigation_manager()->GetLastCommittedItem();
 
   // Verify that |item2|'s UserAgentType is propagated to |item3|.
   EXPECT_EQ(item2->GetUserAgentType(), item3->GetUserAgentType());
 }
 
+// Tests that adding transient item for a pending item with mobile user agent
+// type results in a transient item with mobile user agent type.
+TEST_F(NavigationManagerTest, AddTransientItemForMobilePendingItem) {
+  navigation_manager()->AddPendingItem(
+      GURL("http://www.url.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
+      web::NavigationInitiationType::USER_INITIATED,
+      web::NavigationManager::UserAgentOverrideOption::INHERIT);
+  ASSERT_TRUE(navigation_manager()->GetPendingItem());
+  navigation_manager()->GetPendingItem()->SetUserAgentType(
+      UserAgentType::MOBILE);
+
+  navigation_manager()->AddTransientItem(GURL("http://www.url.com"));
+  ASSERT_TRUE(navigation_manager()->GetTransientItem());
+  EXPECT_EQ(UserAgentType::MOBILE,
+            navigation_manager()->GetTransientItem()->GetUserAgentType());
+  EXPECT_EQ(UserAgentType::MOBILE,
+            navigation_manager()->GetPendingItem()->GetUserAgentType());
+}
+
+// Tests that adding transient item for a pending item with desktop user agent
+// type results in a transient item with desktop user agent type.
+TEST_F(NavigationManagerTest, AddTransientItemForDesktopPendingItem) {
+  navigation_manager()->AddPendingItem(
+      GURL("http://www.url.com"), Referrer(), ui::PAGE_TRANSITION_TYPED,
+      web::NavigationInitiationType::USER_INITIATED,
+      web::NavigationManager::UserAgentOverrideOption::INHERIT);
+  ASSERT_TRUE(navigation_manager()->GetPendingItem());
+  navigation_manager()->GetPendingItem()->SetUserAgentType(
+      UserAgentType::DESKTOP);
+
+  navigation_manager()->AddTransientItem(GURL("http://www.url.com"));
+  ASSERT_TRUE(navigation_manager()->GetTransientItem());
+  EXPECT_EQ(UserAgentType::DESKTOP,
+            navigation_manager()->GetTransientItem()->GetUserAgentType());
+  EXPECT_EQ(UserAgentType::DESKTOP,
+            navigation_manager()->GetPendingItem()->GetUserAgentType());
+}
+
 // Tests that calling |Reload| with web::ReloadType::NORMAL is no-op when there
 // are no transient, pending and committed items.
 TEST_F(NavigationManagerTest, ReloadEmptyWithNormalType) {
   ASSERT_FALSE(navigation_manager()->GetTransientItem());
   ASSERT_FALSE(navigation_manager()->GetPendingItem());
   ASSERT_FALSE(navigation_manager()->GetLastCommittedItem());
 
   navigation_manager()->Reload(web::ReloadType::NORMAL,
                                false /* check_for_repost */);
   EXPECT_FALSE(navigation_manager_delegate().reload_called());
@@ skipping 222 matching lines @@
   navigation_manager()->Reload(web::ReloadType::ORIGINAL_REQUEST_URL,
                                false /* check_for_repost */);
   EXPECT_TRUE(navigation_manager_delegate().reload_called());
 
   ASSERT_TRUE(navigation_manager()->GetLastCommittedItem());
   EXPECT_EQ(expected_original_url,
             navigation_manager()->GetLastCommittedItem()->GetURL());
 }
 
 }  // namespace web