Restrict `@immutable` checks to instance fields

Restrict `@immutable` checks to instance fields

R=brianwilkerson@google.com, pquitslund@google.com

Committed: https://github.com/dart-lang/sdk/commit/c25cd4da33f4b0e96a5ab75274bc209662e4f187

[abarth, 2017-04-05 17:30:51]

I'm not sure how to actually run the tests.  Are there instructions for running
them locally or on a bot?

[Brian Wilkerson, 2017-04-05 17:30:56]

lgtm

[Brian Wilkerson, 2017-04-05 17:34:27]

> I'm not sure how to actually run the tests.

There aren't any directions, but it's fairly easy. Each of the "_test.dart"
files can be run individually, or you can run all of the tests in any given
directory (and all subdirectories) by executing any of the "test_all.dart"
files. There is a "test_all.dart" file in the root of the "analyzer/test"
directory that will run all of the analyzer tests.

[abarth, 2017-04-05 17:37:16]

On 2017/04/05 at 17:34:27, brianwilkerson wrote:
> > I'm not sure how to actually run the tests.
> 
> There aren't any directions, but it's fairly easy. Each of the "_test.dart"
files can be run individually, or you can run all of the tests in any given
directory (and all subdirectories) by executing any of the "test_all.dart"
files. There is a "test_all.dart" file in the root of the "analyzer/test"
directory that will run all of the analyzer tests.

dart/pkg/analyzer$ dart test/generated/hint_code_test.dart 
Unhandled exception:
Could not import "package:test_reflective_loader/test_reflective_loader.dart"
from
"file:///src/flutter/engine/src/dart/pkg/analyzer/test/generated/hint_code_test.dart":
FileSystemException: Cannot open file, path =
'/src/flutter/engine/src/dart/third_party/pkg/test_reflective_loader/lib/test_reflective_loader.dart'
(OS Error: No such file or directory, errno = 2)
null

dart/pkg/analyzer$ pub get
Resolving dependencies... (2.7s)
Package kernel has no versions that match >=0.2.0 <0.3.0 derived from:
- analyzer depends on version ^0.2.0

[abarth, 2017-04-05 17:38:16]

I suspect my working copy is isn't set up properly.  (I just cloned the git
repo.)

[abarth, 2017-04-05 17:44:11]

On 2017/04/05 at 17:38:16, abarth wrote:
> I suspect my working copy is isn't set up properly.  (I just cloned the git
repo.)

I think I see what I did wrong.  I'm supposed to use gclient.

[Brian Wilkerson, 2017-04-05 17:49:03]

Welcome to the SDK and all it's quirks!

You don't want to run pub when working on code in the sdk. There is a
hand-generated '.packages' file in the root of the sdk that is to be used for
everything in the sdk. Please delete any .packages files that were created by
pub.

[Brian Wilkerson, 2017-04-05 17:50:35]

> I'm supposed to use gclient.

Yep. That's the first step. It will create all of the directories under
third_party.

[abarth, 2017-04-05 17:50:45]

Description was changed from

==========
Restrict `@immutable` checks to instance fields

R=brianwilkerson@google.com,pquitslund@google.com
==========

to

==========
Restrict `@immutable` checks to instance fields

R=brianwilkerson@google.com, pquitslund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c25cd4da33f4b0e96a5ab75274bc209662e4f187
==========

[abarth, 2017-04-05 17:50:46]

Committed patchset #1 (id:1) manually as
c25cd4da33f4b0e96a5ab75274bc209662e4f187 (presubmit successful).

[abarth, 2017-04-05 17:51:09]

On 2017/04/05 at 17:50:35, brianwilkerson wrote:
> > I'm supposed to use gclient.
> 
> Yep. That's the first step. It will create all of the directories under
third_party.

Thanks.  I got it working and the tests passes.  :)

[pquitslund, 2017-04-06 14:06:49]

Late to the party, by emphatic LGTM! :)

[pquitslund, 2017-04-06 18:19:18]

Brian: before I forget, has this already been merged or do we need to ask for a
cherry pick?

[pquitslund, 2017-04-06 19:58:07]

On 2017/04/06 18:19:18, pquitslund wrote:
> Brian: before I forget, has this already been merged or do we need to ask for
a
> cherry pick?

Thanks for the sanity check.

Cherry-pick request filed here: https://github.com/dart-lang/sdk/issues/29290.