Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: components/arc/common/power.mojom

Issue 2805433002: Adding ArcBridge interface for synchronizing brightness settings (Closed)
Patch Set: Refactoring Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/arc/power/arc_power_bridge.h » ('j') | components/arc/power/arc_power_bridge.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/arc/common/power.mojom
diff --git a/components/arc/common/power.mojom b/components/arc/common/power.mojom
index 195c7c828e391bbe58138f3472b98c25ba54b0cf..fbfe9cdf958b31c79c55df046882e9413db1c98a 100644
--- a/components/arc/common/power.mojom
+++ b/components/arc/common/power.mojom
@@ -19,7 +19,7 @@ enum DisplayWakeLockType {
DIM = 1
};
-// Next method ID: 3
+// Next method ID: 4
interface PowerHost {
// Acquire and release wake locks on the host side.
OnAcquireDisplayWakeLock@0(DisplayWakeLockType type);
@@ -27,9 +27,13 @@ interface PowerHost {
// Checks if there is a display on.
[MinVersion=1] IsDisplayOn@2() => (bool is_on);
+
+ // Set screen brightness.
+ // |percent| is of the range [0, 100]
+ [MinVersion=2] SetBrightness@3(double percent);
Luis Héctor Chávez 2017/04/05 23:55:27 MinVersion=3 (all the modifications in this chang
yueli 2017/04/06 01:12:36 Done.
};
-// Next method ID: 4
+// Next method ID: 5
interface PowerInstance {
// Establishes full-duplex communication with the host.
Init@0(PowerHost host_ptr);
@@ -43,4 +47,8 @@ interface PowerInstance {
// Called when the system has just resumed.
[MinVersion=2] Resume@3();
+
+ // Update android brightness settings.
Daniel Erat 2017/04/05 23:43:38 nit: s/android/Android/
+ // |percent| is of the range [0, 100]
+ [MinVersion=3] UpdateBrightness@4(double percent);
Daniel Erat 2017/04/05 23:43:38 would UpdateBrightnessSettings be clearer? it's ha
Luis Héctor Chávez 2017/04/05 23:55:27 Can you also throw in "Screen" somewhere in the me
yueli 2017/04/06 01:12:37 Done.
};
« no previous file with comments | « no previous file | components/arc/power/arc_power_bridge.h » ('j') | components/arc/power/arc_power_bridge.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698