Adding ArcBridge interface for synchronizing brightness settings

components/arc/power/arc_power_bridge.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/arc/power/arc_power_bridge.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "ash/shell.h"
 #include "base/logging.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/power_policy_controller.h"
 #include "components/arc/arc_bridge_service.h"
 #include "components/arc/arc_service_manager.h"
 
 namespace arc {
 
 ArcPowerBridge::ArcPowerBridge(ArcBridgeService* bridge_service)
-    : ArcService(bridge_service), binding_(this) {
+    : ArcService(bridge_service), binding_(this), weak_ptr_factory_(this) {
   arc_bridge_service()->power()->AddObserver(this);
 }
 
 ArcPowerBridge::~ArcPowerBridge() {
   arc_bridge_service()->power()->RemoveObserver(this);
   ReleaseAllDisplayWakeLocks();
 }
 
 void ArcPowerBridge::OnInstanceReady() {
   mojom::PowerInstance* power_instance =
       ARC_GET_INSTANCE_FOR_METHOD(arc_bridge_service()->power(), Init);
   DCHECK(power_instance);
   power_instance->Init(binding_.CreateInterfacePtrAndBind());
   ash::Shell::GetInstance()->display_configurator()->AddObserver(this);
   chromeos::DBusThreadManager::Get()->GetPowerManagerClient()->
       AddObserver(this);
+  chromeos::DBusThreadManager::Get()
+      ->GetPowerManagerClient()
+      ->GetScreenBrightnessPercent(base::Bind(&ArcPowerBridge::UpdateBrightness,
+                                              weak_ptr_factory_.GetWeakPtr()));
 }
 
 void ArcPowerBridge::OnInstanceClosed() {
   ash::Shell::GetInstance()->display_configurator()->RemoveObserver(this);
   chromeos::DBusThreadManager::Get()->GetPowerManagerClient()->
       RemoveObserver(this);
   ReleaseAllDisplayWakeLocks();
 }
 
 void ArcPowerBridge::SuspendImminent() {
@@ skipping 20 matching lines @@
     chromeos::DisplayPowerState power_state) {
   mojom::PowerInstance* power_instance = ARC_GET_INSTANCE_FOR_METHOD(
       arc_bridge_service()->power(), SetInteractive);
   if (!power_instance)
     return;
 
   bool enabled = (power_state != chromeos::DISPLAY_POWER_ALL_OFF);
   power_instance->SetInteractive(enabled);
 }
 
+void ArcPowerBridge::UpdateBrightness(double percent) {
+  mojom::PowerInstance* power_instance = ARC_GET_INSTANCE_FOR_METHOD(
+      arc_bridge_service()->power(), UpdateBrightness);
+  if (!power_instance)
+    return;
+  power_instance->UpdateBrightness(percent);

[Daniel Erat, 2017/04/05 23:43:38]

nit: just do:

  if (power_instance)
    power_instance->UpdateBrightness(percent);

+}
+
+void ArcPowerBridge::BrightnessChanged(int level, bool user_initiated) {

[Daniel Erat, 2017/04/05 23:43:38]

please make order of methods in .cc files match order in .h

[yueli, 2017/04/06 01:12:37]

Done.

+  UpdateBrightness(static_cast<double>(level));
+}
+
 void ArcPowerBridge::OnAcquireDisplayWakeLock(mojom::DisplayWakeLockType type) {
   if (!chromeos::PowerPolicyController::IsInitialized()) {
     LOG(WARNING) << "PowerPolicyController is not available";
     return;
   }
   chromeos::PowerPolicyController* controller =
       chromeos::PowerPolicyController::Get();
 
   int wake_lock_id = -1;
   switch (type) {
@@ skipping 32 matching lines @@
   }
   controller->RemoveWakeLock(it->second);
   wake_locks_.erase(it);
 }
 
 void ArcPowerBridge::IsDisplayOn(const IsDisplayOnCallback& callback) {
   callback.Run(
       ash::Shell::GetInstance()->display_configurator()->IsDisplayOn());
 }
 
+void ArcPowerBridge::SetBrightness(double percent) {
+  chromeos::DBusThreadManager::Get()
+      ->GetPowerManagerClient()
+      ->SetScreenBrightnessPercent(percent, true);
+  return;

[Daniel Erat, 2017/04/05 23:43:38]

remove pointless return statement

[yueli, 2017/04/06 01:12:37]

Done.

+}
+
 void ArcPowerBridge::ReleaseAllDisplayWakeLocks() {
   if (!chromeos::PowerPolicyController::IsInitialized()) {
     LOG(WARNING) << "PowerPolicyController is not available";
     return;
   }
   chromeos::PowerPolicyController* controller =
       chromeos::PowerPolicyController::Get();
 
   for (const auto& it : wake_locks_) {
     controller->RemoveWakeLock(it.second);
   }
   wake_locks_.clear();
 }
 
 }  // namespace arc