Adding ArcBridge interface for synchronizing brightness settings

chromeos/dbus/power_manager_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/dbus/power_manager_client.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 #include <memory>
@@ skipping 168 matching lines @@
     dbus::MethodCall method_call(
         power_manager::kPowerManagerInterface,
         power_manager::kGetScreenBrightnessPercentMethod);
     power_manager_proxy_->CallMethod(
         &method_call,
         dbus::ObjectProxy::TIMEOUT_USE_DEFAULT,
         base::Bind(&PowerManagerClientImpl::OnGetScreenBrightnessPercent,
                    weak_ptr_factory_.GetWeakPtr(), callback));
   }
 
+  void SyncScreenBrightness() override {
+    const GetScreenBrightnessPercentCallback& callback =
+        base::Bind(&PowerManagerClientImpl::NotifyBrightnessChanges,
+                   weak_ptr_factory_.GetWeakPtr());

[Muyuan, 2017/04/05 18:41:08]

You can inline callback into next line. Also there is no need for ref const
GetScreenBrightnessPercentCallback&

[yueli, 2017/04/05 19:59:46]

Done.

+    GetScreenBrightnessPercent(callback);
+  }
+
+  void NotifyBrightnessChanges(double percent) {
+    for (auto& observer : observers_)
+      observer.NotifyBrightnessChange(percent);
+  }
+
   void RequestStatusUpdate() override {
     POWER_LOG(USER) << "RequestStatusUpdate";
     dbus::MethodCall method_call(
         power_manager::kPowerManagerInterface,
         power_manager::kGetPowerSupplyPropertiesMethod);
     power_manager_proxy_->CallMethod(
         &method_call,
         dbus::ObjectProxy::TIMEOUT_USE_DEFAULT,
         base::Bind(&PowerManagerClientImpl::OnGetPowerSupplyPropertiesMethod,
                    weak_ptr_factory_.GetWeakPtr()));
@@ skipping 261 matching lines @@
     int32_t brightness_level = 0;
     bool user_initiated = 0;
     if (!(reader.PopInt32(&brightness_level) &&
           reader.PopBool(&user_initiated))) {
       POWER_LOG(ERROR) << "Brightness changed signal had incorrect parameters: "
                        << signal->ToString();
       return;
     }
     POWER_LOG(DEBUG) << "Brightness changed to " << brightness_level
                      << ": user initiated " << user_initiated;
-    for (auto& observer : observers_)
+    for (auto& observer : observers_) {
       observer.BrightnessChanged(brightness_level, user_initiated);
+      observer.NotifyBrightnessChange(static_cast<double>(brightness_level));
+    }
   }
 
   void PeripheralBatteryStatusReceived(dbus::Signal* signal) {
     dbus::MessageReader reader(signal);
     power_manager::PeripheralBatteryStatus protobuf_status;
     if (!reader.PopArrayOfBytesAsProto(&protobuf_status)) {
       POWER_LOG(ERROR) << "Unable to decode protocol buffer from "
                        << power_manager::kPeripheralBatteryStatusSignal
                        << " signal";
       return;
@@ skipping 461 matching lines @@
 // static
 PowerManagerClient* PowerManagerClient::Create(
     DBusClientImplementationType type) {
   if (type == REAL_DBUS_CLIENT_IMPLEMENTATION)
     return new PowerManagerClientImpl();
   DCHECK_EQ(FAKE_DBUS_CLIENT_IMPLEMENTATION, type);
   return new FakePowerManagerClient();
 }
 
 }  // namespace chromeos