Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: chrome/browser/resources/settings/people_page/users_add_user_dialog.html

Issue 2805383002: MD Settings: Users: Fix add person validation and dialog focus (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/users_add_user_dialog.html
diff --git a/chrome/browser/resources/settings/people_page/users_add_user_dialog.html b/chrome/browser/resources/settings/people_page/users_add_user_dialog.html
index 6d812fe8da42d04d4b6a8bdf589faeac87207528..6aef3aa9393dfe62c1f5e3d1458905aadf3fa8cc 100644
--- a/chrome/browser/resources/settings/people_page/users_add_user_dialog.html
+++ b/chrome/browser/resources/settings/people_page/users_add_user_dialog.html
@@ -20,13 +20,15 @@
<div class="title">$i18n{addUsers}</div>
<div class="body">
<paper-input id="addUserInput" label="$i18n{addUsersEmail}" autofocus
- on-input="validate_">
+ on-input="validate_" auto-validate">
dpapad 2017/04/10 17:39:39 What does auto-validate do for us? Is it necessary
stevenjb 2017/04/10 22:02:01 Somehow I thought on-input was a paper-input thing
</paper-input>
</div>
<div class="button-container">
- <paper-button class="cancel-button" on-tap="onCancelTap_"
- id="cancel">$i18n{cancel}</paper-button>
- <paper-button id="add" on-tap="addUser_" class="action-button" disabled>
+ <paper-button class="cancel-button" on-tap="onCancelTap_">
+ $i18n{cancel}
+ </paper-button>
+ <paper-button on-tap="addUser_" class="action-button"
+ disabled$="[[!isValid_]]">
$i18n{add}
</paper-button>
</div>

Powered by Google App Engine
This is Rietveld 408576698