[Payment Request] Selector view controller

ios/chrome/browser/payments/cells/payments_text_item.mm

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/payments/cells/payments_text_item.h"
 
 #import "ios/third_party/material_components_ios/src/components/Palettes/src/MaterialPalettes.h"
 #import "ios/third_party/material_components_ios/src/components/Typography/src/MaterialTypography.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."
 #endif
 
 namespace {
 // Padding of the leading and trailing edges of the cell.
 const CGFloat kHorizontalPadding = 16;
 
 // Padding of the top and bottom edges of the cell.
 const CGFloat kVerticalPadding = 16;
 
 // Spacing between the image and the text label.
 const CGFloat kHorizontalSpacingBetweenImageAndLabel = 8;
 }  // namespace
 
 @implementation PaymentsTextItem
 
 @synthesize text = _text;
 @synthesize image = _image;
+@synthesize textFont = _textFont;
+@synthesize textColor = _textColor;
 
 #pragma mark CollectionViewItem
 
 - (instancetype)initWithType:(NSInteger)type {
   self = [super initWithType:type];
   if (self) {
     self.cellClass = [PaymentsTextCell class];
   }
   return self;
 }
 
+- (UIFont*)textFont {
+  if (!_textFont) {
+    _textFont = [MDCTypography body1Font];
+  }
+  return _textFont;
+}
+
+- (UIColor*)textColor {
+  if (!_textColor) {
+    _textColor = [[MDCPalette greyPalette] tint900];
+  }
+  return _textColor;
+}
+
 - (void)configureCell:(PaymentsTextCell*)cell {
   [super configureCell:cell];
   cell.textLabel.text = self.text;
   cell.imageView.image = self.image;
+
+  // Styling.
+  cell.textLabel.font = self.textFont;
+  cell.textLabel.textColor = self.textColor;
+  cell.textLabel.numberOfLines = 0;

[gambard, 2017/04/11 15:23:25]

For me the item sets only the properties that might be different. I am find with
having a default styling with cell.textLabel.numberOfLines = 0;
cell.textLabel.lineBreakMode = NSLineBreakByWordWrapping; inside the cell
instead of in the item.

[lpromero, 2017/04/11 15:59:06]

+1

[Moe, 2017/04/14 06:05:49]

Done.

+  cell.textLabel.lineBreakMode = NSLineBreakByWordWrapping;
 }
 
 @end
 
 @interface PaymentsTextCell () {
   NSLayoutConstraint* _textLeadingAnchorConstraint;
   NSLayoutConstraint* _imageLeadingAnchorConstraint;
 }
 @end
 
 @implementation PaymentsTextCell
 
 @synthesize textLabel = _textLabel;
 @synthesize imageView = _imageView;
 
 - (instancetype)initWithFrame:(CGRect)frame {
   self = [super initWithFrame:frame];
   if (self) {
     self.isAccessibilityElement = YES;
     [self addSubviews];
-    [self setDefaultViewStyling];
     [self setViewConstraints];
   }
   return self;
 }
 
 // Create and add subviews.
 - (void)addSubviews {
   UIView* contentView = self.contentView;
   contentView.clipsToBounds = YES;
 
   _textLabel = [[UILabel alloc] init];
   _textLabel.translatesAutoresizingMaskIntoConstraints = NO;
   [contentView addSubview:_textLabel];
 
   _imageView = [[UIImageView alloc] initWithFrame:CGRectZero];
   _imageView.translatesAutoresizingMaskIntoConstraints = NO;
   [contentView addSubview:_imageView];
 }
 
-// Set default font and text colors for labels.
-- (void)setDefaultViewStyling {
-  _textLabel.font = [MDCTypography body1Font];
-  _textLabel.textColor = [[MDCPalette greyPalette] tint900];
-  _textLabel.numberOfLines = 0;
-  _textLabel.lineBreakMode = NSLineBreakByWordWrapping;
-}
-
 // Set constraints on subviews.
 - (void)setViewConstraints {
   UIView* contentView = self.contentView;
 
   _textLeadingAnchorConstraint = [_textLabel.leadingAnchor
       constraintEqualToAnchor:_imageView.trailingAnchor];
   _imageLeadingAnchorConstraint = [_imageView.leadingAnchor
       constraintEqualToAnchor:contentView.leadingAnchor
                      constant:kHorizontalPadding];
 
@@ skipping 43 matching lines @@
   self.imageView.image = nil;
 }
 
 #pragma mark - NSObject(Accessibility)
 
 - (NSString*)accessibilityLabel {
   return [NSString stringWithFormat:@"%@", self.textLabel.text];
 }
 
 @end