Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5894)

Unified Diff: chrome/browser/ui/views/payments/profile_list_view_controller.cc

Issue 2805263003: [Payments] Selecting incomplete items will open editors (Closed)
Patch Set: fix ios test for realz Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/profile_list_view_controller.cc
diff --git a/chrome/browser/ui/views/payments/profile_list_view_controller.cc b/chrome/browser/ui/views/payments/profile_list_view_controller.cc
index 3023b234fbbdc9aae574b2decbb166672cbe989d..419b51e4fc07ec05fb7e9b87d7a7c7c1bd70c037 100644
--- a/chrome/browser/ui/views/payments/profile_list_view_controller.cc
+++ b/chrome/browser/ui/views/payments/profile_list_view_controller.cc
@@ -75,12 +75,13 @@ class ProfileItem : public PaymentRequestItemList::Item {
}
bool CanBeSelected() const override {
- // TODO(anthonyvd): Check for profile completedness.
- return true;
+ // TODO(crbug.com/709454): Check for profile completeness. Currently a giant
+ // hack to test the UI.
+ return !profile_->GetRawInfo(autofill::ADDRESS_HOME_ZIP).empty();
}
void PerformSelectionFallback() override {
- // TODO(anthonyvd): Open the editor pre-populated with this profile's data.
+ dialog_->ShowShippingAddressEditor(profile_);
}
ProfileListViewController* parent_view_;

Powered by Google App Engine
This is Rietveld 408576698