chrome/browser/ui/views/payments/credit_card_editor_view_controller_unittest.cc - Issue 2805263003: [Payments] Selecting incomplete items will open editors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/payments/credit_card_editor_view_controller_unittest.cc

Issue 2805263003: [Payments] Selecting incomplete items will open editors (Closed)

Patch Set: addressed comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc ('K') | « chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc ('k') | chrome/browser/ui/views/payments/editor_view_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/payments/credit_card_editor_view_controller_unittest.cc

diff --git a/chrome/browser/ui/views/payments/credit_card_editor_view_controller_unittest.cc b/chrome/browser/ui/views/payments/credit_card_editor_view_controller_unittest.cc

index 9f72e4f52d531ea442f148d4f9216a29c807eb2a..76dba3889e7d169e368b2bfc4401693a62565315 100644

--- a/chrome/browser/ui/views/payments/credit_card_editor_view_controller_unittest.cc

+++ b/chrome/browser/ui/views/payments/credit_card_editor_view_controller_unittest.cc

@@ -28,7 +28,7 @@ TEST(CreditCardEditorViewControllerTest, ExpirationMonth_FromJanuary) {

test_clock.SetNow(kJanuary2017);

std::unique_ptr<CreditCardEditorViewController> view_controller(

- new CreditCardEditorViewController(nullptr, nullptr, nullptr));

+ new CreditCardEditorViewController(nullptr, nullptr, nullptr, nullptr));

std::unique_ptr<ui::ComboboxModel> model =

view_controller->GetComboboxModelForType(autofill::CREDIT_CARD_EXP_MONTH);

@@ -57,7 +57,7 @@ TEST(CreditCardEditorViewControllerTest, ExpirationMonth_FromJune) {

test_clock.SetNow(kJune2017);

std::unique_ptr<CreditCardEditorViewController> view_controller(

- new CreditCardEditorViewController(nullptr, nullptr, nullptr));

+ new CreditCardEditorViewController(nullptr, nullptr, nullptr, nullptr));

std::unique_ptr<ui::ComboboxModel> model =

view_controller->GetComboboxModelForType(autofill::CREDIT_CARD_EXP_MONTH);

@@ -85,7 +85,7 @@ TEST(CreditCardEditorViewControllerTest, ExpirationYear_From2017) {

test_clock.SetNow(kJune2017);

std::unique_ptr<CreditCardEditorViewController> view_controller(

- new CreditCardEditorViewController(nullptr, nullptr, nullptr));

+ new CreditCardEditorViewController(nullptr, nullptr, nullptr, nullptr));

std::unique_ptr<ui::ComboboxModel> model =

view_controller->GetComboboxModelForType(