[Payments] Selecting incomplete items will open editors

components/payments/content/payment_request_state.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/payments/content/payment_request_state.h"
 
 #include <set>
 
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/autofill_data_util.h"
@@ skipping 23 matching lines @@
       selected_instrument_(nullptr),
       payment_request_delegate_(payment_request_delegate) {
   PopulateProfileCache();
   SetDefaultProfileSelections();
 }
 PaymentRequestState::~PaymentRequestState() {}
 
 bool PaymentRequestState::CanMakePayment() const {
   for (const std::unique_ptr<PaymentInstrument>& instrument :
        available_instruments_) {
-    if (instrument.get()->IsValid() &&

[anthonyvd, 2017/04/07 20:08:09]

Is this just that the PR spec doesn't require the instrument to be valid for
CanMakePayment to return true?

[Mathieu, 2017/04/09 00:35:45]

You're right this was unclear. I've rearranged so that the PaymentInstrument API
is clearer, and implemented it to be the same as in Java.

-        spec_->supported_card_networks_set().count(
+    if (spec_->supported_card_networks_set().count(
             instrument.get()->method_name())) {
       return true;
     }
   }
   return false;
 }
 
 void PaymentRequestState::AddObserver(Observer* observer) {
   CHECK(observer);
   observers_.AddObserver(observer);
@@ skipping 208 matching lines @@
            ->GetInfo(autofill::AutofillType(autofill::PHONE_HOME_WHOLE_NUMBER),
                      app_locale_)
            .empty())) {
     return false;
   }
 
   return true;
 }
 
 }  // namespace payments