[Payments] Selecting incomplete items will open editors

chrome/browser/ui/views/payments/editor_view_controller.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/payments/editor_view_controller.h"
 
 #include <map>
 #include <memory>
 #include <utility>
 
@@ skipping 186 matching lines @@
   // A very long label will wrap. Value picked so that left + right label
   // padding bring the label to half-way in the dialog (~225).
   constexpr int kMaximumLabelWidth = 192;
   label->SetMultiLine(true);
   label->SetMaximumWidth(kMaximumLabelWidth);
   layout->AddView(label.release());
 
   if (field.control_type == EditorField::ControlType::TEXTFIELD) {
     ValidatingTextfield* text_field =
         new ValidatingTextfield(CreateValidationDelegate(field));
+    text_field->SetText(GetInitialValueForType(field.type));
     text_field->set_controller(this);
     // Using autofill field type as a view ID (for testing).
     text_field->set_id(static_cast<int>(field.type));
     text_field->set_default_width_in_chars(
         field.length_hint == EditorField::LengthHint::HINT_SHORT
             ? kNumCharactersInShortField
             : kNumCharactersInLongField);
 
     text_fields_.insert(std::make_pair(text_field, field));
     // |text_field| will now be owned by |row|.
     layout->AddView(text_field);
   } else if (field.control_type == EditorField::ControlType::COMBOBOX) {
     ValidatingCombobox* combobox = new ValidatingCombobox(
         GetComboboxModelForType(field.type), CreateValidationDelegate(field));
+    combobox->SelectValue(GetInitialValueForType(field.type));
     // Using autofill field type as a view ID (for testing).
     combobox->set_id(static_cast<int>(field.type));
     combobox->set_listener(this);
     comboboxes_.insert(std::make_pair(combobox, field));
     // |combobox| will now be owned by |row|.
     layout->AddView(combobox);
   } else {
     NOTREACHED();
   }
 
   // This is the vertical space between the input field and its error label.
   constexpr int kInputErrorLabelPadding = 6;
   layout->StartRowWithPadding(0, 0, 0, kInputErrorLabelPadding);
   layout->SkipColumns(1);
   // Error label is initially empty.
   std::unique_ptr<views::Label> error_label =
       base::MakeUnique<views::Label>(base::ASCIIToUTF16(""));
   error_label->set_id(static_cast<int>(DialogViewID::ERROR_LABEL_OFFSET) +
                       field.type);
   error_label->SetFontList(
       error_label->GetDefaultFontList().DeriveWithSizeDelta(-1));
   error_label->SetEnabledColor(error_label->GetNativeTheme()->GetSystemColor(
       ui::NativeTheme::kColorId_AlertSeverityHigh));
   error_labels_[field] = error_label.get();
 
   layout->AddView(error_label.release());
 }
 
 }  // namespace payments