Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2079)

Unified Diff: net/data/verify_certificate_chain_unittest/intermediate-lacks-signing-key-usage/generate-chains.py

Issue 2805213004: Refactor how net/data/verify_certificate_chain_unittest/* (Closed)
Patch Set: fix android Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/data/verify_certificate_chain_unittest/intermediate-lacks-signing-key-usage/generate-chains.py
diff --git a/net/data/verify_certificate_chain_unittest/generate-intermediate-lacks-signing-key-usage.py b/net/data/verify_certificate_chain_unittest/intermediate-lacks-signing-key-usage/generate-chains.py
similarity index 68%
rename from net/data/verify_certificate_chain_unittest/generate-intermediate-lacks-signing-key-usage.py
rename to net/data/verify_certificate_chain_unittest/intermediate-lacks-signing-key-usage/generate-chains.py
index b04faef3c1b32ca9808891add3849e0193b20f55..42cb22fdc18e7ae1f184e3d0ffd67c4a733c4b50 100755
--- a/net/data/verify_certificate_chain_unittest/generate-intermediate-lacks-signing-key-usage.py
+++ b/net/data/verify_certificate_chain_unittest/intermediate-lacks-signing-key-usage/generate-chains.py
@@ -7,6 +7,9 @@
contains a keyUsage extension, HOWEVER it does not contain the keyCertSign bit.
Hence validation is expected to fail."""
+import sys
+sys.path += ['..']
+
import common
# Self-signed root certificate (used as trust anchor).
@@ -20,15 +23,5 @@ intermediate.get_extensions().set_property('keyUsage',
# Target certificate.
target = common.create_end_entity_certificate('Target', intermediate)
-chain = [target, intermediate]
-trusted = common.TrustAnchor(root, constrained=False)
-time = common.DEFAULT_TIME
-key_purpose = common.DEFAULT_KEY_PURPOSE
-verify_result = False
-errors = """----- Certificate i=1 (CN=Intermediate) -----
-ERROR: keyCertSign bit is not set
-
-"""
-
-common.write_test_file(__doc__, chain, trusted, time, key_purpose,
- verify_result, errors)
+chain = [target, intermediate, root]
+common.write_chain(__doc__, chain, 'chain.pem')

Powered by Google App Engine
This is Rietveld 408576698